Paul Fagerburg has submitted this change. ( https://review.coreboot.org/c/coreboot/+/73635 )
Change subject: soc/amd/common/block/cpu/noncar/write_resume_eip: use raw MSR data ......................................................................
soc/amd/common/block/cpu/noncar/write_resume_eip: use raw MSR data
Since mst_t is a union of the struct containing the lower and higher 32 bits and the raw 64 bit value, the address of the bootblock_resume_entry can be directly written to the raw value instead of needing to split it into the lower and higher 32 bits and assigning those separately.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Suggested-by: Arthur Heymans arthur@aheymans.xyz Change-Id: I7ebab1784ec592e18c29001b1cf3ee7790615bf8 Reviewed-on: https://review.coreboot.org/c/coreboot/+/73635 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martin.roth@amd.corp-partner.google.com --- M src/soc/amd/common/block/cpu/noncar/write_resume_eip.c 1 file changed, 20 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/src/soc/amd/common/block/cpu/noncar/write_resume_eip.c b/src/soc/amd/common/block/cpu/noncar/write_resume_eip.c index 5863917..ea43d7a 100644 --- a/src/soc/amd/common/block/cpu/noncar/write_resume_eip.c +++ b/src/soc/amd/common/block/cpu/noncar/write_resume_eip.c @@ -12,8 +12,7 @@ void write_resume_eip(void) { msr_t s3_resume_entry = { - .hi = (uint64_t)(uintptr_t)bootblock_resume_entry >> 32, - .lo = (uintptr_t)bootblock_resume_entry & 0xffffffff, + .raw = (uintptr_t)bootblock_resume_entry, };
/*