Attention is currently required from: Jamie Chen, shkim, SH Kim, Patrick Rudolph, Karthik Ramasubramanian.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57201 )
Change subject: soc/intel/jasperlake: Utilize vbt data size Kconfig option
......................................................................
Patch Set 6:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57201/comment/48f511c2_076e7f1b
PS6, Line 8:
Please describe the problem first.
https://review.coreboot.org/c/coreboot/+/57201/comment/f400039f_e39b6806
PS6, Line 9: cf5d58328f(increase vbt_data size)
Please add a space before the (.
https://review.coreboot.org/c/coreboot/+/57201/comment/b396df5d_40e31a35
PS6, Line 9: had changed
changes or changed
https://review.coreboot.org/c/coreboot/+/57201/comment/0ced7cbf_9952757c
PS6, Line 11: jasperlake
Jasper Lake
https://review.coreboot.org/c/coreboot/+/57201/comment/8807234d_be50f416
PS6, Line 10: to pick
: the size for jasperlake.
… to set the size to 9 KB for Jasper Lake.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57201
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0abe1ba5609b48a8a8b15f88bec28342ce26c78f
Gerrit-Change-Number: 57201
Gerrit-PatchSet: 6
Gerrit-Owner: shkim
sh_.kim@samsung.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jamie Chen
jamie.chen@intel.corp-partner.google.com
Gerrit-Attention: shkim
sh_.kim@samsung.com
Gerrit-Attention: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 02 Sep 2021 06:58:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment