Attention is currently required from: Felix Singer.
Nico Huber has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83226?usp=email )
Change subject: Makefile.mk: Use one line per *_common flag ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I don't like this rule at all. […]
I didn't mean this as a general rule. Just for people who want to do bulk style changes without hurting the project. Style changes in general are not bad. It's just bulk changes to adapt to ones own liking that cause trouble.
Of course people can just adapt and be done with it. But there are deeper psychological aspects, e.g. somebody who just had to adapt due to bikeshedding might just give up when they are hit by controversial bulk changes on top. With that in mind, I think it just needs balance, a trade-off between cleaning things up and creative work.
Please keep in mind that a lot of the creative coreboot work is done unpaid. And unpaid people can just choose not to update their changes.