Vincent Palatin has posted comments on this change. ( https://review.coreboot.org/26684 )
Change subject: mb/google/poppy/variants/nocturne: configure the FPMCU interface
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/26684/1/src/mainboard/google/poppy/variants/...
File src/mainboard/google/poppy/variants/nocturne/gpio.c:
https://review.coreboot.org/#/c/26684/1/src/mainboard/google/poppy/variants/...
PS1, Line 136: 0
I had missed this on the other CL. […]
Done
--
To view, visit
https://review.coreboot.org/26684
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib417dcf84cda8e354060785cd16a7b6b812148d5
Gerrit-Change-Number: 26684
Gerrit-PatchSet: 2
Gerrit-Owner: Vincent Palatin
vpalatin@chromium.org
Gerrit-Reviewer: Vincent Palatin
vpalatin@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Wed, 30 May 2018 11:58:08 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No