Attention is currently required from: Jérémy Compostella, Patrick Rudolph, Shuo Liu.
Jincheng Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81260?usp=email )
Change subject: arch/x86: Fix typo for macro CPUID_FEATURE_HTT
......................................................................
Patch Set 7:
(1 comment)
File src/arch/x86/include/arch/cpu.h:
https://review.coreboot.org/c/coreboot/+/81260/comment/4a83ac12_8ccb0642 :
PS7, Line 50: CPUID_FEATURE_PAE
Unused defines
CPUID_FEATURE_PAE is used in src/arch/x86/cpu_common.c:59
"if (cpuid_edx(1) & (CPUID_FEATURE_PAE | CPUID_FEATURE_PSE36))"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81260?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9b29233e75483cda6bf7723cf79632f6b04233b0
Gerrit-Change-Number: 81260
Gerrit-PatchSet: 7
Gerrit-Owner: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Comment-Date: Tue, 19 Mar 2024 01:59:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment