Attention is currently required from: Hung-Te Lin, Jarried Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85948?usp=email )
Change subject: soc/mediatek: Correct value's data type to u8 in dptx_hal_set_txlane api
......................................................................
Patch Set 3:
(1 comment)
File src/soc/mediatek/common/dp/include/soc/dptx_hal_common.h:
https://review.coreboot.org/c/coreboot/+/85948/comment/1047d2b8_f4db8793?usp... :
PS2, Line 87: int
Can we also fix this?
Update?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85948?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I60bbb2c37811655692a5a8cd9f942fed4ead8abb
Gerrit-Change-Number: 85948
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Fri, 17 Jan 2025 00:59:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com