Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Yu-Ping Wu.
Karthik Ramasubramanian has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83564?usp=email )
Change subject: soc/amd/cezanne: Give PSP verstage 4K more space
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/cezanne/include/soc/psp_verstage_addr.h:
https://review.coreboot.org/c/coreboot/+/83564/comment/9ced0144_cdf2b00b?usp... :
PS2, Line 20: #define PSP_VERSTAGE_STACK_START 0x42000
: #define PSP_VERSTAGE_STACK_SIZE (36K)
The stack size and start address is a contract between PSP Bootloader and Verstage. So changing it here alone will break that contract.
I am wondering if there are any clang compiler settings that can satisfy the memory layout requirements. Since we need to fix the original issue, let us just do `
cmos_write(RTC_FREQ_SELECT_AMD, RTC_FREQ_SELECT);` in vbnv_platform_init_cmos for now and revisit switching to cmos_init(0) later.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83564?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9f53a45d67782d3e425f423d0715a45482b2edea
Gerrit-Change-Number: 83564
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 19 Jul 2024 16:38:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No