Change in coreboot[master]: mb/google/zork: config I2C2 freq to 400kHz for dirinboz TP/TS
Hello Kevin Chiu,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/44515
to review the following change.
Change subject: mb/google/zork: config I2C2 freq to 400kHz for dirinboz TP/TS ......................................................................
mb/google/zork: config I2C2 freq to 400kHz for dirinboz TP/TS
BUG=b:159597999,b:159597998 BRANCH=master TEST=1. emerge-zork coreboot chromeos-bootimage 2. power on proto board successfully 3. measure i2c freq by scope is 400kHz
Change-Id: Icb27ff8a4960caaebc542ee4e507f1611da5a77e Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/dirinboz/overridetree.cb 1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/44515/1
diff --git a/src/mainboard/google/zork/variants/dirinboz/overridetree.cb b/src/mainboard/google/zork/variants/dirinboz/overridetree.cb index 7645ba3..0667943 100644 --- a/src/mainboard/google/zork/variants/dirinboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/dirinboz/overridetree.cb @@ -1,5 +1,4 @@ # SPDX-License-Identifier: GPL-2.0-or-later - chip soc/amd/picasso
# Start : OPN Performance Configuration @@ -18,10 +17,12 @@
# End : OPN Performance Configuration
- # I2C2 for touchscreen and trackpad
+ # I2C2 for touchscreen and trackpad register "i2c[2]" = "{ .speed = I2C_SPEED_FAST, + .rise_time_ns = 18, /* 0 to 2.31 (3.3 * .7) */ + .fall_time_ns = 57, /* 2.31 to 0 */ }"
# I2C3 for H1
Hello Kevin Chiu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44515
to look at the new patch set (#2).
Change subject: mb/google/zork: Adjust Dirinboz I2C values ......................................................................
mb/google/zork: Adjust Dirinboz I2C values
BUG=b:164757545 BRANCH=master TEST=1. emerge-zork coreboot chromeos-bootimage 2. power on proto board successfully 3. measure i2c freq by scope is close to 400kHz
Change-Id: Icb27ff8a4960caaebc542ee4e507f1611da5a77e Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/dirinboz/overridetree.cb 1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/44515/2
Hello Kevin Chiu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44515
to look at the new patch set (#3).
Change subject: mb/google/zork: Adjust Dirinboz I2C values ......................................................................
mb/google/zork: Adjust Dirinboz I2C values
BUG=b:164757545 BRANCH=master TEST=1. emerge-zork coreboot chromeos-bootimage 2. power on proto board successfully 3. measure i2c freq by scope is close to 400kHz
Change-Id: Icb27ff8a4960caaebc542ee4e507f1611da5a77e Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/dirinboz/overridetree.cb 1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/44515/3
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44515 )
Change subject: mb/google/zork: Adjust Dirinboz I2C values ......................................................................
Patch Set 3: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44515 )
Change subject: mb/google/zork: Adjust Dirinboz I2C values ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44515 )
Change subject: mb/google/zork: Adjust Dirinboz I2C values ......................................................................
mb/google/zork: Adjust Dirinboz I2C values
BUG=b:164757545 BRANCH=master TEST=1. emerge-zork coreboot chromeos-bootimage 2. power on proto board successfully 3. measure i2c freq by scope is close to 400kHz
Change-Id: Icb27ff8a4960caaebc542ee4e507f1611da5a77e Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44515 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/zork/variants/dirinboz/overridetree.cb 1 file changed, 5 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/dirinboz/overridetree.cb b/src/mainboard/google/zork/variants/dirinboz/overridetree.cb index 7645ba3..c43063c 100644 --- a/src/mainboard/google/zork/variants/dirinboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/dirinboz/overridetree.cb @@ -1,5 +1,4 @@ # SPDX-License-Identifier: GPL-2.0-or-later - chip soc/amd/picasso
# Start : OPN Performance Configuration @@ -18,16 +17,19 @@
# End : OPN Performance Configuration
- # I2C2 for touchscreen and trackpad
+ # I2C2 for touchscreen and trackpad register "i2c[2]" = "{ .speed = I2C_SPEED_FAST, + .rise_time_ns = 18, /* 0 to 2.31 (3.3 * .7) */ + .fall_time_ns = 57, /* 2.31 to 0 */ }"
# I2C3 for H1 - register "i2c[3]" = "{ .speed = I2C_SPEED_FAST, + .rise_time_ns = 184, /* 0 to 1.26v (1.8 * .7) */ + .fall_time_ns = 42, /* 1.26v to 0 */ .early_init = true, }"
-
Aaron Durbin (Code Review) -
Furquan Shaikh (Code Review)
-
Kevin Chiu (Code Review)
-
Patrick Georgi (Code Review)