[S] Change in coreboot[master]: mb/{system76,msi}: Enable PchHdaAudioLinkHdaEnable via devicetree

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/71717 )

Change subject: mb/{system76,msi}: Enable PchHdaAudioLinkHdaEnable via devicetree
......................................................................

mb/{system76,msi}: Enable PchHdaAudioLinkHdaEnable via devicetree

Signed-off-by: Sean Rhodes 
Change-Id: Iae2dc0a934f0ea3ca59d8a811f1daeedb090a7bd
Reviewed-on: https://review.coreboot.org/c/coreboot/+/71717
Tested-by: build bot (Jenkins) 
Reviewed-by: Michał Kopeć 
---
M src/mainboard/msi/ms7d25/devicetree.cb
M src/mainboard/msi/ms7d25/romstage_fsp_params.c
M src/mainboard/system76/adl/devicetree.cb
M src/mainboard/system76/adl/variants/darp8/romstage.c
M src/mainboard/system76/adl/variants/galp6/romstage.c
5 files changed, 15 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Michał Kopeć: Looks good to me, approved

diff --git a/src/mainboard/msi/ms7d25/devicetree.cb b/src/mainboard/msi/ms7d25/devicetree.cb
index 189faf6..d50a950 100644
--- a/src/mainboard/msi/ms7d25/devicetree.cb
+++ b/src/mainboard/msi/ms7d25/devicetree.cb
@@ -261,6 +261,7 @@
    	device ref p2sb on end
    	device ref hda on
    		subsystemid 0x1462 0x9d25
+			register "pch_hda_audio_link_hda_enable" = "1"
    		register "pch_hda_dsp_enable" = "0"
    		register "pch_hda_idisp_link_tmode" = "HDA_TMODE_8T"
    		register "pch_hda_idisp_link_frequency" = "HDA_LINKFREQ_96MHZ"
diff --git a/src/mainboard/msi/ms7d25/romstage_fsp_params.c b/src/mainboard/msi/ms7d25/romstage_fsp_params.c
index 707f871..9a18f13 100644
--- a/src/mainboard/msi/ms7d25/romstage_fsp_params.c
+++ b/src/mainboard/msi/ms7d25/romstage_fsp_params.c
@@ -57,7 +57,6 @@
    memupd->FspmConfig.DmiMaxLinkSpeed = 4; // Gen4 speed, undocumented
    memupd->FspmConfig.SkipExtGfxScan = 0;

-	memupd->FspmConfig.PchHdaAudioLinkHdaEnable = 1;
    memupd->FspmConfig.PchHdaSdiEnable[0] = 1;

/*
diff --git a/src/mainboard/system76/adl/devicetree.cb b/src/mainboard/system76/adl/devicetree.cb
index 8f668be..d469491 100644
--- a/src/mainboard/system76/adl/devicetree.cb
+++ b/src/mainboard/system76/adl/devicetree.cb
@@ -84,6 +84,7 @@
    	end
    	device ref p2sb on end
    	device ref hda on
+			register "pch_hda_audio_link_hda_enable" = "1"
    		register "pch_hda_idisp_codec_enable" = "1"
    		register "pch_hda_idisp_link_frequency" = "HDA_LINKFREQ_96MHZ"
    		register "pch_hda_idisp_link_tmode" = "HDA_TMODE_8T"
diff --git a/src/mainboard/system76/adl/variants/darp8/romstage.c b/src/mainboard/system76/adl/variants/darp8/romstage.c
index 3d6a5fb..e6cf37f 100644
--- a/src/mainboard/system76/adl/variants/darp8/romstage.c
+++ b/src/mainboard/system76/adl/variants/darp8/romstage.c
@@ -17,7 +17,6 @@
    };
    const bool half_populated = false;

-	mupd->FspmConfig.PchHdaAudioLinkHdaEnable = 1;
    mupd->FspmConfig.DmiMaxLinkSpeed = 4;
    mupd->FspmConfig.GpioOverride = 0;

diff --git a/src/mainboard/system76/adl/variants/galp6/romstage.c b/src/mainboard/system76/adl/variants/galp6/romstage.c
index 3d6a5fb..e6cf37f 100644
--- a/src/mainboard/system76/adl/variants/galp6/romstage.c
+++ b/src/mainboard/system76/adl/variants/galp6/romstage.c
@@ -17,7 +17,6 @@
    };
    const bool half_populated = false;

-	mupd->FspmConfig.PchHdaAudioLinkHdaEnable = 1;
    mupd->FspmConfig.DmiMaxLinkSpeed = 4;
    mupd->FspmConfig.GpioOverride = 0;