Change in coreboot[master]: mb/google/puff: Enable SPD_READ_BY_WORD to short the boottime
Jamie Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38848 )
Change subject: mb/google/puff: Enable SPD_READ_BY_WORD to short the boottime ......................................................................
mb/google/puff: Enable SPD_READ_BY_WORD to short the boottime
Puff uses the smbus to access SPD of memory DIMM. Add select SPD_READ_BY_WORD under BOARD_GOOGLE_PUFF in Kconfig.name It's for shorting the SPD reading time.
BUG=b:149360051 BRANCH=None TEST=build puff and boot up OS ran cbmem -t | grep FspMemoryInit Without this patch: 950:calling FspMemoryInit 643,199 (257,588) With this patch: 950:calling FspMemoryInit 477,714 (154,612)
Signed-off-by: Jamie Chen jamie.chen@intel.com Change-Id: I161e8eb386ab604b16746f0deeecc3d6c9063c3a --- M src/mainboard/google/hatch/Kconfig.name 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/38848/1
diff --git a/src/mainboard/google/hatch/Kconfig.name b/src/mainboard/google/hatch/Kconfig.name index e216135..2427b12 100644 --- a/src/mainboard/google/hatch/Kconfig.name +++ b/src/mainboard/google/hatch/Kconfig.name @@ -48,6 +48,7 @@ select BOARD_GOOGLE_BASEBOARD_HATCH select BOARD_ROMSIZE_KB_32768 select ROMSTAGE_SPD_SMBUS + select SPD_READ_BY_WORD
config BOARD_GOOGLE_HELIOS_DISKSWAP bool "-> Helios_Diskswap"
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38848
to look at the new patch set (#2).
Change subject: mb/google/puff: Enable SPD_READ_BY_WORD to short the boottime ......................................................................
mb/google/puff: Enable SPD_READ_BY_WORD to short the boottime
Puff uses the smbus to access the SPD of memory DIMMs. It will short the SPD reading time if enabling SPD_READ_BY_WORD.
BUG=b:149360051 BRANCH=None TEST=build puff and boot up OS ran cbmem -t | grep FspMemoryInit Without this patch: 950:calling FspMemoryInit 643,199 (257,588) With this patch: 950:calling FspMemoryInit 477,714 (154,612)
Signed-off-by: Jamie Chen jamie.chen@intel.com Change-Id: I161e8eb386ab604b16746f0deeecc3d6c9063c3a --- M src/mainboard/google/hatch/Kconfig.name 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/38848/2
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38848 )
Change subject: mb/google/puff: Enable SPD_READ_BY_WORD to short the boottime ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38848 )
Change subject: mb/google/puff: Enable SPD_READ_BY_WORD to short the boottime ......................................................................
Patch Set 3: Code-Review+1
Nice!
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38848 )
Change subject: mb/google/puff: Enable SPD_READ_BY_WORD to short the boottime ......................................................................
mb/google/puff: Enable SPD_READ_BY_WORD to short the boottime
Puff uses the smbus to access the SPD of memory DIMMs. It will short the SPD reading time if enabling SPD_READ_BY_WORD.
BUG=b:149360051 BRANCH=None TEST=build puff and boot up OS ran cbmem -t | grep FspMemoryInit Without this patch: 950:calling FspMemoryInit 643,199 (257,588) With this patch: 950:calling FspMemoryInit 477,714 (154,612)
Signed-off-by: Jamie Chen jamie.chen@intel.com Change-Id: I161e8eb386ab604b16746f0deeecc3d6c9063c3a Reviewed-on: https://review.coreboot.org/c/coreboot/+/38848 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Edward O'Callaghan quasisec@chromium.org --- M src/mainboard/google/hatch/Kconfig.name 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Edward O'Callaghan: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/Kconfig.name b/src/mainboard/google/hatch/Kconfig.name index e216135..2427b12 100644 --- a/src/mainboard/google/hatch/Kconfig.name +++ b/src/mainboard/google/hatch/Kconfig.name @@ -48,6 +48,7 @@ select BOARD_GOOGLE_BASEBOARD_HATCH select BOARD_ROMSIZE_KB_32768 select ROMSTAGE_SPD_SMBUS + select SPD_READ_BY_WORD
config BOARD_GOOGLE_HELIOS_DISKSWAP bool "-> Helios_Diskswap"
-
Edward O'Callaghan (Code Review) -
Jamie Chen (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)