Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43141 )
Change subject: mb/google/volteer: Rename remaining pmc_mux/con to conn ......................................................................
mb/google/volteer: Rename remaining pmc_mux/con to conn
CB:43090 renamed con to conn to avoid issues when building on Windows. CB:42905 introduced more uses of the old name.
Adapt the latter to comply with the former.
Change-Id: I723141add5452fc541f67cb8591793f2d64cc231 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb M src/mainboard/google/volteer/variants/voxel/overridetree.cb 2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/43141/1
diff --git a/src/mainboard/google/volteer/variants/volteer/overridetree.cb b/src/mainboard/google/volteer/variants/volteer/overridetree.cb index 577f7c8..404b257 100644 --- a/src/mainboard/google/volteer/variants/volteer/overridetree.cb +++ b/src/mainboard/google/volteer/variants/volteer/overridetree.cb @@ -163,7 +163,7 @@ probe DB_USB USB3_NO_A end end - chip drivers/intel/pmc_mux/con + chip drivers/intel/pmc_mux/conn register "usb2_port_number" = "4" register "usb3_port_number" = "2" # SBU & HSL follow CC diff --git a/src/mainboard/google/volteer/variants/voxel/overridetree.cb b/src/mainboard/google/volteer/variants/voxel/overridetree.cb index 9ee7e6a..2219de0 100644 --- a/src/mainboard/google/volteer/variants/voxel/overridetree.cb +++ b/src/mainboard/google/volteer/variants/voxel/overridetree.cb @@ -111,14 +111,14 @@ # PMC.MUX device in the ACPI hierarchy. chip drivers/intel/pmc_mux device generic 0 on - chip drivers/intel/pmc_mux/con + chip drivers/intel/pmc_mux/conn register "usb2_port_number" = "9" register "usb3_port_number" = "1" # SBU is fixed, HSL follows CC register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL" device generic 0 on end end - chip drivers/intel/pmc_mux/con + chip drivers/intel/pmc_mux/conn register "usb2_port_number" = "4" register "usb3_port_number" = "2" # SBU is fixed, HSL follows CC
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43141 )
Change subject: mb/google/volteer: Rename remaining pmc_mux/con to conn ......................................................................
Patch Set 1: Code-Review+1
It’d be great to use git commit hashes in the git commit message, as that is how git can be used on the command line.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43141 )
Change subject: mb/google/volteer: Rename remaining pmc_mux/con to conn ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
It’d be great to use git commit hashes in the git commit message, as that is how git can be used on the command line.
I prefer this style because it's so much shorter. For commit hashes to remain stable you have to provide their long form (because otherwise another commit with the same prefix can appear later, making "123abc" ambiguous).
I wonder if we should provide tooling to resolve the short forms on the CLI, that is, provide a script or alias to resolve CB:* and CL:* with something like
git log --pretty="commit %h" --grep "^Reviewed-on: http[s]*://review.coreboot.org/.*/43090$"
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43141 )
Change subject: mb/google/volteer: Rename remaining pmc_mux/con to conn ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43141 )
Change subject: mb/google/volteer: Rename remaining pmc_mux/con to conn ......................................................................
Patch Set 1: Code-Review+2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43141 )
Change subject: mb/google/volteer: Rename remaining pmc_mux/con to conn ......................................................................
Patch Set 1: Code-Review+2
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43141 )
Change subject: mb/google/volteer: Rename remaining pmc_mux/con to conn ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43141 )
Change subject: mb/google/volteer: Rename remaining pmc_mux/con to conn ......................................................................
Patch Set 1:
It’d be great to use git commit hashes in the git commit message, as that is how git can be used on the command line.
I prefer this style because it's so much shorter. For commit hashes to remain stable you have to provide their long form (because otherwise another commit with the same prefix can appear later, making "123abc" ambiguous).
Technically, a short hash can become ambiguous... But if you have two or more hits, it's usually clear that you are looking for the oldest of the matches. Not sure where it came from, but for some time '%h (%s)' seemed to be the encouraged way to reference older commits.
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43141 )
Change subject: mb/google/volteer: Rename remaining pmc_mux/con to conn ......................................................................
mb/google/volteer: Rename remaining pmc_mux/con to conn
CB:43090 renamed con to conn to avoid issues when building on Windows. CB:42905 introduced more uses of the old name.
Adapt the latter to comply with the former.
Change-Id: I723141add5452fc541f67cb8591793f2d64cc231 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43141 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Felix Singer felixsinger@posteo.net Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Christian Walter christian.walter@9elements.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb M src/mainboard/google/volteer/variants/voxel/overridetree.cb 2 files changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Arthur Heymans: Looks good to me, approved Felix Singer: Looks good to me, approved Christian Walter: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/volteer/overridetree.cb b/src/mainboard/google/volteer/variants/volteer/overridetree.cb index 577f7c8..404b257 100644 --- a/src/mainboard/google/volteer/variants/volteer/overridetree.cb +++ b/src/mainboard/google/volteer/variants/volteer/overridetree.cb @@ -163,7 +163,7 @@ probe DB_USB USB3_NO_A end end - chip drivers/intel/pmc_mux/con + chip drivers/intel/pmc_mux/conn register "usb2_port_number" = "4" register "usb3_port_number" = "2" # SBU & HSL follow CC diff --git a/src/mainboard/google/volteer/variants/voxel/overridetree.cb b/src/mainboard/google/volteer/variants/voxel/overridetree.cb index 9ee7e6a..2219de0 100644 --- a/src/mainboard/google/volteer/variants/voxel/overridetree.cb +++ b/src/mainboard/google/volteer/variants/voxel/overridetree.cb @@ -111,14 +111,14 @@ # PMC.MUX device in the ACPI hierarchy. chip drivers/intel/pmc_mux device generic 0 on - chip drivers/intel/pmc_mux/con + chip drivers/intel/pmc_mux/conn register "usb2_port_number" = "9" register "usb3_port_number" = "1" # SBU is fixed, HSL follows CC register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL" device generic 0 on end end - chip drivers/intel/pmc_mux/con + chip drivers/intel/pmc_mux/conn register "usb2_port_number" = "4" register "usb3_port_number" = "2" # SBU is fixed, HSL follows CC
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43141 )
Change subject: mb/google/volteer: Rename remaining pmc_mux/con to conn ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 1/3/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : FAIL : https://lava.9esec.io/r/8267 "QEMU x86 q35/ich9" using payload SeaBIOS : FAIL : https://lava.9esec.io/r/8266 "QEMU x86 i440fx/piix4" using payload SeaBIOS : FAIL : https://lava.9esec.io/r/8265 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/8264
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Arthur Heymans (Code Review)
-
Christian Walter (Code Review)
-
Felix Singer (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)