Attention is currently required from: Hung-Te Lin, Jakub Czapiga, Julius Werner, Arthur Heymans.
Jianjun Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63494 )
Change subject: coreboot_tables: Replace 'struct lb_uint64' with lb_uint64_t
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS5:
Sorry, forgot that earlier... but we should do the same thing on the libpayload side as well. […]
Done, is that ok to have the same define in payloads/libpayload/include/coreboot_tables.h:
typedef __aligned(4) uint64_t cb_uint64_t;
Or should we use a common header file in commonlib/bsd?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63494
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6b037e4403a8000625f4a5fb8d20311fe76200a
Gerrit-Change-Number: 63494
Gerrit-PatchSet: 6
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 13 Apr 2022 02:21:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment