Attention is currently required from: Paul Menzel, Eric Peers, Rob Barnes, Karthik Ramasubramanian, Felix Held. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57263 )
Change subject: mb/google/guybrush/nipperkin: update nipperkin config ......................................................................
Patch Set 3:
(4 comments)
File src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/57263/comment/8c598987_e71c1274 PS2, Line 57: /D2
Nit: No D2.
Done
https://review.coreboot.org/c/coreboot/+/57263/comment/b1f2b48f_557cb6e7 PS2, Line 76: device ref i2c_0 on : chip drivers/i2c/generic : register "hid" = ""ELAN0000"" : register "desc" = ""ELAN Touchpad"" : register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_9)" : register "wake" = "GEVENT_22" : register "probed" = "1" : device i2c 15 on end : end : end # I2C0 : : device ref i2c_1 on : chip drivers/i2c/hid : register "generic.hid" = ""GDIX0000"" : register "generic.desc" = ""Goodix Touchscreen"" : register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_89)" : register "generic.probed" = "1" : register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_68)" : register "generic.enable_delay_ms" = "10" : register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_121)" : register "generic.reset_off_delay_ms" = "1" : register "generic.reset_delay_ms" = "10" : register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_120)" : register "generic.stop_delay_ms" = "170" : register "generic.stop_off_delay_ms" = "1" : register "generic.has_power_resource" = "1" : register "hid_desc_reg_offset" = "0x01" : device i2c 5d on end : end
I dont see the build details anywhere. […]
yes, it's copied from: src/mainboard/google/guybrush/variants/guybrush/overridetree.cb
https://review.coreboot.org/c/coreboot/+/57263/comment/ea071ab1_6993ded9 PS2, Line 131: chip drivers/i2c/generic : register "hid" = ""10EC1019"" : register "desc" = ""Realtek SPK AMP L"" : register "uid" = "0" : register "probed" = "1" : device i2c 28 on end : end : chip drivers/i2c/generic : register "hid" = ""10EC1019"" : register "desc" = ""Realtek SPK AMP R"" : register "uid" = "1" : device i2c 29 on end : end
Learnt through this bug: https://b.corp.google. […]
let's remove it and submit anther patch for MAX98360A, thanks.
https://review.coreboot.org/c/coreboot/+/57263/comment/fbc4a75c_13876b02 PS2, Line 144: chip drivers/i2c/generic : register "hid" = ""10EC1019"" : register "desc" = ""Realtek SPK AMP L1"" : register "uid" = "2" : register "probed" = "1" : device i2c 2a on end : end
Either Speaker Amp L1 or Speaker Amp L is sufficient and we dont need both. […]
let's remove it and submit anther patch for MAX98360A, thanks.