Change in ...coreboot[master]: src: Use macro `ACPI_FADT_LEGACY_FREE`

[Paul Menzel (Code Review)]

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31289

Change subject: src: Use macro `ACPI_FADT_LEGACY_FREE`
......................................................................

src: Use macro `ACPI_FADT_LEGACY_FREE`

Replace all instances, where 0 is used by the macro/define
`ACPI_FADT_LEGACY_FREE`.

Change-Id: I226b334620e0cdafc7639c7a76ea3a523ae53a74
Signed-off-by: Paul Menzel 
---
M src/mainboard/emulation/qemu-q35/acpi_tables.c
M src/mainboard/lenovo/t400/fadt.c
M src/mainboard/lenovo/x200/fadt.c
M src/mainboard/roda/rk9/fadt.c
M src/soc/intel/fsp_broadwell_de/acpi.c
M src/soc/intel/skylake/acpi.c
M src/southbridge/nvidia/ck804/fadt.c
M src/southbridge/nvidia/mcp55/fadt.c
8 files changed, 8 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/31289/1

diff --git a/src/mainboard/emulation/qemu-q35/acpi_tables.c b/src/mainboard/emulation/qemu-q35/acpi_tables.c
index 99184ca..6fdc77f 100644
--- a/src/mainboard/emulation/qemu-q35/acpi_tables.c
+++ b/src/mainboard/emulation/qemu-q35/acpi_tables.c
@@ -92,7 +92,7 @@
    fadt->day_alrm = 0xd;
    fadt->mon_alrm = 0x00;
    fadt->century = 0x32;
-	fadt->iapc_boot_arch = 0x00;
+	fadt->iapc_boot_arch = ACPI_FADT_LEGACY_FREE;
    fadt->flags = ACPI_FADT_WBINVD | ACPI_FADT_C1_SUPPORTED |
    		ACPI_FADT_SLEEP_BUTTON | ACPI_FADT_S4_RTC_WAKE |
    		ACPI_FADT_DOCKING_SUPPORTED | ACPI_FADT_RESET_REGISTER |
diff --git a/src/mainboard/lenovo/t400/fadt.c b/src/mainboard/lenovo/t400/fadt.c
index ab257f8..31336db 100644
--- a/src/mainboard/lenovo/t400/fadt.c
+++ b/src/mainboard/lenovo/t400/fadt.c
@@ -71,7 +71,7 @@
    fadt->day_alrm = 0xd;
    fadt->mon_alrm = 0x00;
    fadt->century = 0x32;
-	fadt->iapc_boot_arch = 0x00;
+	fadt->iapc_boot_arch = ACPI_FADT_LEGACY_FREE;
    fadt->flags = ACPI_FADT_WBINVD | ACPI_FADT_C1_SUPPORTED |
    		ACPI_FADT_SLEEP_BUTTON | ACPI_FADT_S4_RTC_WAKE |
    		ACPI_FADT_DOCKING_SUPPORTED | ACPI_FADT_RESET_REGISTER |
diff --git a/src/mainboard/lenovo/x200/fadt.c b/src/mainboard/lenovo/x200/fadt.c
index ab257f8..31336db 100644
--- a/src/mainboard/lenovo/x200/fadt.c
+++ b/src/mainboard/lenovo/x200/fadt.c
@@ -71,7 +71,7 @@
    fadt->day_alrm = 0xd;
    fadt->mon_alrm = 0x00;
    fadt->century = 0x32;
-	fadt->iapc_boot_arch = 0x00;
+	fadt->iapc_boot_arch = ACPI_FADT_LEGACY_FREE;
    fadt->flags = ACPI_FADT_WBINVD | ACPI_FADT_C1_SUPPORTED |
    		ACPI_FADT_SLEEP_BUTTON | ACPI_FADT_S4_RTC_WAKE |
    		ACPI_FADT_DOCKING_SUPPORTED | ACPI_FADT_RESET_REGISTER |
diff --git a/src/mainboard/roda/rk9/fadt.c b/src/mainboard/roda/rk9/fadt.c
index ab257f8..31336db 100644
--- a/src/mainboard/roda/rk9/fadt.c
+++ b/src/mainboard/roda/rk9/fadt.c
@@ -71,7 +71,7 @@
    fadt->day_alrm = 0xd;
    fadt->mon_alrm = 0x00;
    fadt->century = 0x32;
-	fadt->iapc_boot_arch = 0x00;
+	fadt->iapc_boot_arch = ACPI_FADT_LEGACY_FREE;
    fadt->flags = ACPI_FADT_WBINVD | ACPI_FADT_C1_SUPPORTED |
    		ACPI_FADT_SLEEP_BUTTON | ACPI_FADT_S4_RTC_WAKE |
    		ACPI_FADT_DOCKING_SUPPORTED | ACPI_FADT_RESET_REGISTER |
diff --git a/src/soc/intel/fsp_broadwell_de/acpi.c b/src/soc/intel/fsp_broadwell_de/acpi.c
index 71aa0a3..aa572ea 100644
--- a/src/soc/intel/fsp_broadwell_de/acpi.c
+++ b/src/soc/intel/fsp_broadwell_de/acpi.c
@@ -222,7 +222,7 @@
    fadt->day_alrm       = 0x0D;
    fadt->mon_alrm       = 0x00;
    fadt->century        = 0x00;
-	fadt->iapc_boot_arch = 0;
+	fadt->iapc_boot_arch = ACPI_FADT_LEGACY_FREE;

fadt->flags = ACPI_FADT_WBINVD | ACPI_FADT_C1_SUPPORTED |
    		ACPI_FADT_C2_MP_SUPPORTED | ACPI_FADT_SLEEP_BUTTON |
diff --git a/src/soc/intel/skylake/acpi.c b/src/soc/intel/skylake/acpi.c
index f6eb659..3ad1e50 100644
--- a/src/soc/intel/skylake/acpi.c
+++ b/src/soc/intel/skylake/acpi.c
@@ -275,7 +275,7 @@
    fadt->day_alrm = 0xd;
    fadt->mon_alrm = 0x00;
    fadt->century = 0x00;
-	fadt->iapc_boot_arch = 0;
+	fadt->iapc_boot_arch = ACPI_FADT_LEGACY_FREE;
    if (!IS_ENABLED(CONFIG_NO_FADT_8042))
    	fadt->iapc_boot_arch |= ACPI_FADT_8042;

diff --git a/src/southbridge/nvidia/ck804/fadt.c b/src/southbridge/nvidia/ck804/fadt.c
index ee9db2f..fb4cbb6 100644
--- a/src/southbridge/nvidia/ck804/fadt.c
+++ b/src/southbridge/nvidia/ck804/fadt.c
@@ -82,7 +82,7 @@
    fadt->day_alrm = 0x7d;
    fadt->mon_alrm = 0x7e;
    fadt->century = 0x32;
-	fadt->iapc_boot_arch = 0;
+	fadt->iapc_boot_arch = ACPI_FADT_LEGACY_FREE;
    fadt->flags = 0xa5;

#ifdef LONG_FADT
diff --git a/src/southbridge/nvidia/mcp55/fadt.c b/src/southbridge/nvidia/mcp55/fadt.c
index 8064b12..f1d6e9d 100644
--- a/src/southbridge/nvidia/mcp55/fadt.c
+++ b/src/southbridge/nvidia/mcp55/fadt.c
@@ -93,7 +93,7 @@
    fadt->mon_alrm = 0x7e;
    fadt->century = 0x32;

-	fadt->iapc_boot_arch = 0x0;
+	fadt->iapc_boot_arch = ACPI_FADT_LEGACY_FREE;

fadt->flags = 0x4a5;
    fadt->reset_reg.space_id = 0;

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31289 )

Change subject: src: Use macro `ACPI_FADT_LEGACY_FREE`
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31289/1/src/soc/intel/fsp_broadwell_de/acpi.... 
File src/soc/intel/fsp_broadwell_de/acpi.c:

https://review.coreboot.org/#/c/31289/1/src/soc/intel/fsp_broadwell_de/acpi.... 
PS1, Line 19: #include <string.h>
missing #include <arch/acpi.h>

[Paul Menzel (Code Review)]

Hello Alexander Couzens, Patrick Rudolph, York Yang, Philipp Deppenwiese, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31289

to look at the new patch set (#2).

Change subject: src: Use macro `ACPI_FADT_LEGACY_FREE`
......................................................................

src: Use macro `ACPI_FADT_LEGACY_FREE`

Replace all instances, where 0 is used by the macro/define
`ACPI_FADT_LEGACY_FREE`.

Change-Id: I226b334620e0cdafc7639c7a76ea3a523ae53a74
Signed-off-by: Paul Menzel 
---
M src/mainboard/emulation/qemu-q35/acpi_tables.c
M src/mainboard/lenovo/t400/fadt.c
M src/mainboard/lenovo/x200/fadt.c
M src/mainboard/roda/rk9/fadt.c
M src/soc/intel/fsp_broadwell_de/acpi.c
M src/soc/intel/skylake/acpi.c
M src/southbridge/nvidia/ck804/fadt.c
M src/southbridge/nvidia/mcp55/fadt.c
8 files changed, 9 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/31289/2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31289 )

Change subject: src: Use macro `ACPI_FADT_LEGACY_FREE`
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/31289/1/src/soc/intel/fsp_broadwell_de/acpi.... 
File src/soc/intel/fsp_broadwell_de/acpi.c:

https://review.coreboot.org/#/c/31289/1/src/soc/intel/fsp_broadwell_de/acpi.... 
PS1, Line 19: #include <string.h>
> missing #include <arch/acpi. […]

Done

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31289 )

Change subject: src: Use macro `ACPI_FADT_LEGACY_FREE`
......................................................................

Patch Set 2: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31289 )

Change subject: src: Use macro `ACPI_FADT_LEGACY_FREE`
......................................................................

src: Use macro `ACPI_FADT_LEGACY_FREE`

Replace all instances, where 0 is used by the macro/define
`ACPI_FADT_LEGACY_FREE`.

Change-Id: I226b334620e0cdafc7639c7a76ea3a523ae53a74
Signed-off-by: Paul Menzel 
Reviewed-on: https://review.coreboot.org/c/31289
Tested-by: build bot (Jenkins) 
Reviewed-by: HAOUAS Elyes 
---
M src/mainboard/emulation/qemu-q35/acpi_tables.c
M src/mainboard/lenovo/t400/fadt.c
M src/mainboard/lenovo/x200/fadt.c
M src/mainboard/roda/rk9/fadt.c
M src/soc/intel/fsp_broadwell_de/acpi.c
M src/soc/intel/skylake/acpi.c
M src/southbridge/nvidia/ck804/fadt.c
M src/southbridge/nvidia/mcp55/fadt.c
8 files changed, 9 insertions(+), 8 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  HAOUAS Elyes: Looks good to me, approved

diff --git a/src/mainboard/emulation/qemu-q35/acpi_tables.c b/src/mainboard/emulation/qemu-q35/acpi_tables.c
index 99184ca..6fdc77f 100644
--- a/src/mainboard/emulation/qemu-q35/acpi_tables.c
+++ b/src/mainboard/emulation/qemu-q35/acpi_tables.c
@@ -92,7 +92,7 @@
    fadt->day_alrm = 0xd;
    fadt->mon_alrm = 0x00;
    fadt->century = 0x32;
-	fadt->iapc_boot_arch = 0x00;
+	fadt->iapc_boot_arch = ACPI_FADT_LEGACY_FREE;
    fadt->flags = ACPI_FADT_WBINVD | ACPI_FADT_C1_SUPPORTED |
    		ACPI_FADT_SLEEP_BUTTON | ACPI_FADT_S4_RTC_WAKE |
    		ACPI_FADT_DOCKING_SUPPORTED | ACPI_FADT_RESET_REGISTER |
diff --git a/src/mainboard/lenovo/t400/fadt.c b/src/mainboard/lenovo/t400/fadt.c
index ab257f8..31336db 100644
--- a/src/mainboard/lenovo/t400/fadt.c
+++ b/src/mainboard/lenovo/t400/fadt.c
@@ -71,7 +71,7 @@
    fadt->day_alrm = 0xd;
    fadt->mon_alrm = 0x00;
    fadt->century = 0x32;
-	fadt->iapc_boot_arch = 0x00;
+	fadt->iapc_boot_arch = ACPI_FADT_LEGACY_FREE;
    fadt->flags = ACPI_FADT_WBINVD | ACPI_FADT_C1_SUPPORTED |
    		ACPI_FADT_SLEEP_BUTTON | ACPI_FADT_S4_RTC_WAKE |
    		ACPI_FADT_DOCKING_SUPPORTED | ACPI_FADT_RESET_REGISTER |
diff --git a/src/mainboard/lenovo/x200/fadt.c b/src/mainboard/lenovo/x200/fadt.c
index ab257f8..31336db 100644
--- a/src/mainboard/lenovo/x200/fadt.c
+++ b/src/mainboard/lenovo/x200/fadt.c
@@ -71,7 +71,7 @@
    fadt->day_alrm = 0xd;
    fadt->mon_alrm = 0x00;
    fadt->century = 0x32;
-	fadt->iapc_boot_arch = 0x00;
+	fadt->iapc_boot_arch = ACPI_FADT_LEGACY_FREE;
    fadt->flags = ACPI_FADT_WBINVD | ACPI_FADT_C1_SUPPORTED |
    		ACPI_FADT_SLEEP_BUTTON | ACPI_FADT_S4_RTC_WAKE |
    		ACPI_FADT_DOCKING_SUPPORTED | ACPI_FADT_RESET_REGISTER |
diff --git a/src/mainboard/roda/rk9/fadt.c b/src/mainboard/roda/rk9/fadt.c
index ab257f8..31336db 100644
--- a/src/mainboard/roda/rk9/fadt.c
+++ b/src/mainboard/roda/rk9/fadt.c
@@ -71,7 +71,7 @@
    fadt->day_alrm = 0xd;
    fadt->mon_alrm = 0x00;
    fadt->century = 0x32;
-	fadt->iapc_boot_arch = 0x00;
+	fadt->iapc_boot_arch = ACPI_FADT_LEGACY_FREE;
    fadt->flags = ACPI_FADT_WBINVD | ACPI_FADT_C1_SUPPORTED |
    		ACPI_FADT_SLEEP_BUTTON | ACPI_FADT_S4_RTC_WAKE |
    		ACPI_FADT_DOCKING_SUPPORTED | ACPI_FADT_RESET_REGISTER |
diff --git a/src/soc/intel/fsp_broadwell_de/acpi.c b/src/soc/intel/fsp_broadwell_de/acpi.c
index 71aa0a3..fa45ea7 100644
--- a/src/soc/intel/fsp_broadwell_de/acpi.c
+++ b/src/soc/intel/fsp_broadwell_de/acpi.c
@@ -18,6 +18,7 @@

#include <string.h>
 #include <types.h>
+#include <arch/acpi.h>
 #include <arch/acpigen.h>
 #include <arch/io.h>
 #include <arch/smp/mpspec.h>
@@ -222,7 +223,7 @@
    fadt->day_alrm       = 0x0D;
    fadt->mon_alrm       = 0x00;
    fadt->century        = 0x00;
-	fadt->iapc_boot_arch = 0;
+	fadt->iapc_boot_arch = ACPI_FADT_LEGACY_FREE;

fadt->flags = ACPI_FADT_WBINVD | ACPI_FADT_C1_SUPPORTED |
    		ACPI_FADT_C2_MP_SUPPORTED | ACPI_FADT_SLEEP_BUTTON |
diff --git a/src/soc/intel/skylake/acpi.c b/src/soc/intel/skylake/acpi.c
index f6eb659..3ad1e50 100644
--- a/src/soc/intel/skylake/acpi.c
+++ b/src/soc/intel/skylake/acpi.c
@@ -275,7 +275,7 @@
    fadt->day_alrm = 0xd;
    fadt->mon_alrm = 0x00;
    fadt->century = 0x00;
-	fadt->iapc_boot_arch = 0;
+	fadt->iapc_boot_arch = ACPI_FADT_LEGACY_FREE;
    if (!IS_ENABLED(CONFIG_NO_FADT_8042))
    	fadt->iapc_boot_arch |= ACPI_FADT_8042;

diff --git a/src/southbridge/nvidia/ck804/fadt.c b/src/southbridge/nvidia/ck804/fadt.c
index ee9db2f..fb4cbb6 100644
--- a/src/southbridge/nvidia/ck804/fadt.c
+++ b/src/southbridge/nvidia/ck804/fadt.c
@@ -82,7 +82,7 @@
    fadt->day_alrm = 0x7d;
    fadt->mon_alrm = 0x7e;
    fadt->century = 0x32;
-	fadt->iapc_boot_arch = 0;
+	fadt->iapc_boot_arch = ACPI_FADT_LEGACY_FREE;
    fadt->flags = 0xa5;

#ifdef LONG_FADT
diff --git a/src/southbridge/nvidia/mcp55/fadt.c b/src/southbridge/nvidia/mcp55/fadt.c
index 8064b12..f1d6e9d 100644
--- a/src/southbridge/nvidia/mcp55/fadt.c
+++ b/src/southbridge/nvidia/mcp55/fadt.c
@@ -93,7 +93,7 @@
    fadt->mon_alrm = 0x7e;
    fadt->century = 0x32;

-	fadt->iapc_boot_arch = 0x0;
+	fadt->iapc_boot_arch = ACPI_FADT_LEGACY_FREE;

fadt->flags = 0x4a5;
    fadt->reset_reg.space_id = 0;