Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/82629?usp=email )
Change subject: mb/google/trulo: Refactor gpio pad configuration
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS3:
But are we expect the variant have a lot difference with baseboard? That will have a lot dup codes in gpio table.
yes, these are partner designs hence expecting to have significant delta over GPIO config. Moreover our Rex model tells us having different gpio.c for variants helps a lot ODM to do their own work w/o bothering to aligning it to baseboard.
Commit Message:
https://review.coreboot.org/c/coreboot/+/82629/comment/749e02cb_8ea2bf9d?usp... :
PS3, Line 7: mb/google/brya/bb/trulo
if this is baseboard, we can just use mb/google/trulo
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82629?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4ab88ac094a45c608cd894feb5eeec24b867527a
Gerrit-Change-Number: 82629
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 24 May 2024 03:56:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com