Attention is currently required from: Tim Wawrzynczak, Michael Niewöhner.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52548 )
Change subject: cpu/x86/msr: introduce helpers msr_read, msr_write
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
File src/include/cpu/x86/msr.h:
https://review.coreboot.org/c/coreboot/+/52548/comment/6f5451cb_79bb0942
PS5, Line 323: unsigned int
i was wondering why this is not uint32_t, but this matches the definition of the fields of msr_t. not 100% sure if it would be a good idea to change the msr_t element data types from unsigned int to uint32_t, but that would be someting for a follow-up patch, since it's out of scope for this one
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52548
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27333a4bdfe3c8cebfe49a16a4f1a066f558c4ce
Gerrit-Change-Number: 52548
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Wed, 28 Apr 2021 16:00:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment