Change in coreboot[master]: mb: Enable ISH 'firmware-name' device property on TGL via ACPI _DSD t...
Hello Jes Klinke,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/39482
to review the following change.
Change subject: mb: Enable ISH 'firmware-name' device property on TGL via ACPI _DSD table ......................................................................
mb: Enable ISH 'firmware-name' device property on TGL via ACPI _DSD table
Upstream of mainboard parts of commit c88f7d29565a5f24603bc6cf235d8f3d7d1caf12.
Change-Id: Ibc3d4c4ca5ea12d89cef8a4e37ecd4c3c2eb2e2d Signed-off-by: Hu, Hebo hebo.hu@intel.com --- M src/mainboard/intel/tglrvp/Kconfig M src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb M src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb 3 files changed, 18 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/39482/1
diff --git a/src/mainboard/intel/tglrvp/Kconfig b/src/mainboard/intel/tglrvp/Kconfig index 2051a05..d60918f 100644 --- a/src/mainboard/intel/tglrvp/Kconfig +++ b/src/mainboard/intel/tglrvp/Kconfig @@ -14,6 +14,7 @@ select GENERATE_SMBIOS_TABLES select SOC_INTEL_TIGERLAKE select INTEL_LPSS_UART_FOR_CONSOLE + select DRIVERS_INTEL_ISH
config CHROMEOS bool diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb index 4492acb..ea2b264 100644 --- a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb +++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb @@ -133,6 +133,14 @@ device pci 10.2 off end # CNVi: BT 0xA0F5 - A0F7 device pci 10.6 off end # THC0 0xA0D0 device pci 10.7 off end # THC1 0xA0D1 + + device pci 12.0 off # SensorHUB 0xA0FC + chip drivers/intel/ish + register "firmware_name" = ""tglrvp_ish.bin"" + device generic 0 on end + end + end + device pci 12.0 off end # SensorHUB 0xA0FC device pci 12.6 off end # GSPI2 0x34FB device pci 13.0 off end # GSPI3 0xA0FD diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb index 643db36..b3558ca 100644 --- a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb +++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb @@ -129,7 +129,15 @@ device pci 10.2 off end # CNVi: BT 0xA0F5 - A0F7 device pci 10.6 off end # THC0 0xA0D0 device pci 10.7 off end # THC1 0xA0D1 - device pci 12.0 off end # SensorHUB 0xA0FC + + device pci 12.0 off # SensorHUB 0xA0FC + chip drivers/intel/ish + register "firmware_name" = ""tglrvp_ish.bin"" + device generic 0 on end + end + end + + device pci 12.6 off end # GSPI2 0x34FB device pci 13.0 off end # GSPI3 0xA0FD device pci 14.0 on end # USB3.1 xHCI 0xA0ED
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39482 )
Change subject: mb: Enable ISH 'firmware-name' device property on TGL via ACPI _DSD table ......................................................................
Patch Set 1: Code-Review+1
Jes Klinke has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39482 )
Change subject: mb: Enable ISH 'firmware-name' device property on TGL via ACPI _DSD table ......................................................................
Patch Set 1: Code-Review-1
I have become aware that Intel engineers are also pushing this upstream, see: https://review.coreboot.org/c/coreboot/+/39478 https://review.coreboot.org/c/coreboot/+/39480 https://review.coreboot.org/c/coreboot/+/39481
Jes Klinke has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/39482 )
Change subject: mb: Enable ISH 'firmware-name' device property on TGL via ACPI _DSD table ......................................................................
Abandoned
Functionality already implemented.
-
Caveh Jalali (Code Review) -
Jes Klinke (Code Review)