Change in ...coreboot[master]: mb/google/poppy/var/rammus: Enable mode change wake source for S3/S0ix
Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31296
Change subject: mb/google/poppy/var/rammus: Enable mode change wake source for S3/S0ix ......................................................................
mb/google/poppy/var/rammus: Enable mode change wake source for S3/S0ix
This change enables mode change as a wake source for S3 and S0ix.
Change-Id: I2e7f9997776b1e024ea417eb69e6c2ffa8c62580 Signed-off-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/poppy/variants/rammus/include/variant/ec.h 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/31296/1
diff --git a/src/mainboard/google/poppy/variants/rammus/include/variant/ec.h b/src/mainboard/google/poppy/variants/rammus/include/variant/ec.h index d4a07b5..ac17745 100644 --- a/src/mainboard/google/poppy/variants/rammus/include/variant/ec.h +++ b/src/mainboard/google/poppy/variants/rammus/include/variant/ec.h @@ -51,7 +51,8 @@ */ #define MAINBOARD_EC_S3_WAKE_EVENTS \ (MAINBOARD_EC_S5_WAKE_EVENTS |\ - EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED)) + EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE))
#define MAINBOARD_EC_S0IX_WAKE_EVENTS (MAINBOARD_EC_S3_WAKE_EVENTS)
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31296 )
Change subject: mb/google/poppy/var/rammus: Enable mode change wake source for S3/S0ix ......................................................................
Patch Set 1: Code-Review+1
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31296 )
Change subject: mb/google/poppy/var/rammus: Enable mode change wake source for S3/S0ix ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31296 )
Change subject: mb/google/poppy/var/rammus: Enable mode change wake source for S3/S0ix ......................................................................
mb/google/poppy/var/rammus: Enable mode change wake source for S3/S0ix
This change enables mode change as a wake source for S3 and S0ix.
Change-Id: I2e7f9997776b1e024ea417eb69e6c2ffa8c62580 Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/31296 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Zhuohao Lee zhuohao@chromium.org Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/mainboard/google/poppy/variants/rammus/include/variant/ec.h 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Zhuohao Lee: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/poppy/variants/rammus/include/variant/ec.h b/src/mainboard/google/poppy/variants/rammus/include/variant/ec.h index d4a07b5..ac17745 100644 --- a/src/mainboard/google/poppy/variants/rammus/include/variant/ec.h +++ b/src/mainboard/google/poppy/variants/rammus/include/variant/ec.h @@ -51,7 +51,8 @@ */ #define MAINBOARD_EC_S3_WAKE_EVENTS \ (MAINBOARD_EC_S5_WAKE_EVENTS |\ - EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED)) + EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE))
#define MAINBOARD_EC_S0IX_WAKE_EVENTS (MAINBOARD_EC_S3_WAKE_EVENTS)
-
Aaron Durbin (Code Review) -
Furquan Shaikh (Code Review)
-
Zhuohao Lee (Code Review)