Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86425?usp=email )
Change subject: mb/siemens/fa_ehl/variants/fa_ehl: Remove I210 driver ......................................................................
mb/siemens/fa_ehl/variants/fa_ehl: Remove I210 driver
Intel I210 Ethernet Transceiver is not used on the platform. As there are dependencies in the mainboard code that references functions defined by I210 code a new header (tsn_gbe.h) was added as it contains the dependent function definitions. The corresponding TSN_GBE driver will be used anyway on the platform. Thereby dependencies that lead to a failed build should be resolved with this commit.
Change-Id: I413cb334ee06e3fc7183dc2621b6091f0d0b602b Signed-off-by: Johannes Hahn johannes-hahn@siemens.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/86425 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Mario Scheithauer mario.scheithauer@siemens.com --- M src/mainboard/siemens/fa_ehl/mainboard.c M src/mainboard/siemens/fa_ehl/variants/fa_ehl/Kconfig 2 files changed, 1 insertion(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Mario Scheithauer: Looks good to me, approved
diff --git a/src/mainboard/siemens/fa_ehl/mainboard.c b/src/mainboard/siemens/fa_ehl/mainboard.c index ac16346..31f4dd7 100644 --- a/src/mainboard/siemens/fa_ehl/mainboard.c +++ b/src/mainboard/siemens/fa_ehl/mainboard.c @@ -8,9 +8,9 @@ #include <device/pci_ops.h> #include <device/pci_ids.h> #include <hwilib.h> -#include <i210.h> #include <soc/gpio.h> #include <soc/ramstage.h> +#include <soc/tsn_gbe.h> #include <string.h> #include <timer.h> #include <timestamp.h> diff --git a/src/mainboard/siemens/fa_ehl/variants/fa_ehl/Kconfig b/src/mainboard/siemens/fa_ehl/variants/fa_ehl/Kconfig index 0f3544c..76096a4 100644 --- a/src/mainboard/siemens/fa_ehl/variants/fa_ehl/Kconfig +++ b/src/mainboard/siemens/fa_ehl/variants/fa_ehl/Kconfig @@ -4,7 +4,6 @@
config BOARD_SPECIFIC_OPTIONS def_bool y - select DRIVER_INTEL_I210 select EHL_TSN_DRIVER select DRIVERS_ETH_PHY_M88E1512