Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41939 )
Change subject: soc/intel/broadwell: Move include folder to northbridge ......................................................................
soc/intel/broadwell: Move include folder to northbridge
Since we process soc files before southbridge files, the cppflags override does not work as intended if placed in the southbridge.
And yes, some prototypes are now in the wrong place. This will be fixed in the next commits, once the soc/intel/broadwell subfolder is no more.
With BUILD_TIMELESS=1 but without adding the .config file into the resulting coreboot image, google/auron (Buddy) remains identical.
Change-Id: Iaa773923e37536d92cf54825db3291af2b3d9b54 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/broadwell/Makefile.inc R src/northbridge/intel/broadwell/include/soc/msr.h R src/northbridge/intel/broadwell/include/soc/nvs.h R src/northbridge/intel/broadwell/include/soc/systemagent.h D src/soc/intel/broadwell/Makefile.inc 5 files changed, 2 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/41939/1
diff --git a/src/northbridge/intel/broadwell/Makefile.inc b/src/northbridge/intel/broadwell/Makefile.inc index cbcc631..51cf4a8 100644 --- a/src/northbridge/intel/broadwell/Makefile.inc +++ b/src/northbridge/intel/broadwell/Makefile.inc @@ -1,5 +1,7 @@ ifeq ($(CONFIG_NORTHBRIDGE_INTEL_BROADWELL),y)
+CPPFLAGS_common += -Isrc/northbridge/intel/broadwell/include + bootblock-y += bootblock.c
ramstage-y += finalize.c diff --git a/src/soc/intel/broadwell/include/soc/msr.h b/src/northbridge/intel/broadwell/include/soc/msr.h similarity index 100% rename from src/soc/intel/broadwell/include/soc/msr.h rename to src/northbridge/intel/broadwell/include/soc/msr.h diff --git a/src/soc/intel/broadwell/include/soc/nvs.h b/src/northbridge/intel/broadwell/include/soc/nvs.h similarity index 100% rename from src/soc/intel/broadwell/include/soc/nvs.h rename to src/northbridge/intel/broadwell/include/soc/nvs.h diff --git a/src/soc/intel/broadwell/include/soc/systemagent.h b/src/northbridge/intel/broadwell/include/soc/systemagent.h similarity index 100% rename from src/soc/intel/broadwell/include/soc/systemagent.h rename to src/northbridge/intel/broadwell/include/soc/systemagent.h diff --git a/src/soc/intel/broadwell/Makefile.inc b/src/soc/intel/broadwell/Makefile.inc deleted file mode 100644 index dada3d1..0000000 --- a/src/soc/intel/broadwell/Makefile.inc +++ /dev/null @@ -1,5 +0,0 @@ -ifeq ($(CONFIG_SOC_INTEL_BROADWELL),y) - -CPPFLAGS_common += -Isrc/soc/intel/broadwell/include - -endif
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41939
to look at the new patch set (#9).
Change subject: soc/intel/broadwell: Move include folder to northbridge ......................................................................
soc/intel/broadwell: Move include folder to northbridge
Since we process soc files before southbridge files, the cppflags override does not work as intended if placed in the southbridge.
And yes, some prototypes are now in the wrong place. This will be fixed in the next commits, once the soc/intel/broadwell subfolder is no more.
With BUILD_TIMELESS=1 but without adding the .config file into the resulting coreboot image, google/auron (Buddy) remains identical.
Change-Id: Iaa773923e37536d92cf54825db3291af2b3d9b54 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/broadwell/Makefile.inc R src/northbridge/intel/broadwell/include/soc/msr.h R src/northbridge/intel/broadwell/include/soc/nvs.h R src/northbridge/intel/broadwell/include/soc/systemagent.h D src/soc/intel/broadwell/Makefile.inc 5 files changed, 2 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/41939/9
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41939
to look at the new patch set (#12).
Change subject: soc/intel/broadwell: Move include folder to northbridge ......................................................................
soc/intel/broadwell: Move include folder to northbridge
Since we process soc files before southbridge files, the cppflags override does not work as intended if placed in the southbridge.
And yes, some prototypes are now in the wrong place. This will be fixed in the next commits, once the soc/intel/broadwell subfolder is no more.
With BUILD_TIMELESS=1 but without adding the .config file into the resulting coreboot image, google/auron (Buddy) remains identical.
Change-Id: Iaa773923e37536d92cf54825db3291af2b3d9b54 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/broadwell/Makefile.inc R src/northbridge/intel/broadwell/include/soc/msr.h R src/northbridge/intel/broadwell/include/soc/nvs.h R src/northbridge/intel/broadwell/include/soc/systemagent.h D src/soc/intel/broadwell/Makefile.inc 5 files changed, 2 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/41939/12
Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41939 )
Change subject: soc/intel/broadwell: Move include folder to northbridge ......................................................................
Abandoned
-
Angel Pons (Code Review)