Change in coreboot[master]: mb/Kconfig: Move MAINBOARD_FAMILY type definition to mb/Kconfig
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45123 )
Change subject: mb/Kconfig: Move MAINBOARD_FAMILY type definition to mb/Kconfig ......................................................................
mb/Kconfig: Move MAINBOARD_FAMILY type definition to mb/Kconfig
Change-Id: If007988496c972185bad097535c5fd30ccfcd45b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/51nb/x210/Kconfig M src/mainboard/Kconfig M src/mainboard/bostentech/Kconfig M src/mainboard/facebook/monolith/Kconfig M src/mainboard/google/beltino/Kconfig M src/mainboard/google/cyan/Kconfig M src/mainboard/google/dedede/Kconfig M src/mainboard/google/deltaur/Kconfig M src/mainboard/google/drallion/Kconfig M src/mainboard/google/eve/Kconfig M src/mainboard/google/fizz/Kconfig M src/mainboard/google/glados/Kconfig M src/mainboard/google/hatch/Kconfig M src/mainboard/google/kahlee/Kconfig M src/mainboard/google/octopus/Kconfig M src/mainboard/google/poppy/Kconfig M src/mainboard/google/reef/Kconfig M src/mainboard/google/sarien/Kconfig M src/mainboard/google/slippy/Kconfig M src/mainboard/google/volteer/Kconfig M src/mainboard/google/zork/Kconfig M src/mainboard/intel/cannonlake_rvp/Kconfig M src/mainboard/intel/coffeelake_rvp/Kconfig M src/mainboard/intel/glkrvp/Kconfig M src/mainboard/intel/icelake_rvp/Kconfig M src/mainboard/intel/jasperlake_rvp/Kconfig M src/mainboard/intel/kblrvp/Kconfig M src/mainboard/intel/kunimitsu/Kconfig M src/mainboard/intel/saddlebrook/Kconfig M src/mainboard/intel/tglrvp/Kconfig M src/mainboard/lenovo/Kconfig M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/tiogapass/Kconfig M src/mainboard/prodrive/hermes/Kconfig M src/mainboard/purism/librem_bdw/Kconfig M src/mainboard/purism/librem_skl/Kconfig M src/mainboard/purism/librem_whl/Kconfig M src/mainboard/razer/blade_stealth_kbl/Kconfig M src/mainboard/supermicro/x11-lga1151-series/Kconfig 39 files changed, 5 insertions(+), 38 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/45123/1
diff --git a/src/mainboard/51nb/x210/Kconfig b/src/mainboard/51nb/x210/Kconfig index 824e8b3..771cb30 100644 --- a/src/mainboard/51nb/x210/Kconfig +++ b/src/mainboard/51nb/x210/Kconfig @@ -13,7 +13,6 @@ select SYSTEM_TYPE_LAPTOP
config MAINBOARD_FAMILY - string default "X210"
config MAINBOARD_PART_NUMBER diff --git a/src/mainboard/Kconfig b/src/mainboard/Kconfig index 9ab047c..2cb932f 100644 --- a/src/mainboard/Kconfig +++ b/src/mainboard/Kconfig @@ -11,6 +11,11 @@ config MAINBOARD_VENDOR string "Mainboard vendor name"
+config MAINBOARD_FAMILY + string + help + This text string identifies the family to which a particular computer belongs. + source "src/mainboard/*/Kconfig"
config BOARD_ROMSIZE_KB_64 diff --git a/src/mainboard/bostentech/Kconfig b/src/mainboard/bostentech/Kconfig index 15a7657..01c8850 100644 --- a/src/mainboard/bostentech/Kconfig +++ b/src/mainboard/bostentech/Kconfig @@ -13,7 +13,6 @@ default "Shenzhen Bostrontium Teng Technology"
config MAINBOARD_FAMILY - string default MAINBOARD_PART_NUMBER
endif # VENDOR_BOSTENTECH diff --git a/src/mainboard/facebook/monolith/Kconfig b/src/mainboard/facebook/monolith/Kconfig index 92c02a7..8e5cce7 100644 --- a/src/mainboard/facebook/monolith/Kconfig +++ b/src/mainboard/facebook/monolith/Kconfig @@ -30,7 +30,6 @@ default "Monolith"
config MAINBOARD_FAMILY - string default "Facebook Monolith"
config MAX_CPUS diff --git a/src/mainboard/google/beltino/Kconfig b/src/mainboard/google/beltino/Kconfig index 0ac6805..0a7412b 100644 --- a/src/mainboard/google/beltino/Kconfig +++ b/src/mainboard/google/beltino/Kconfig @@ -40,7 +40,6 @@ default "Zako" if BOARD_GOOGLE_ZAKO
config MAINBOARD_FAMILY - string default "Google_Beltino"
config VGA_BIOS_FILE diff --git a/src/mainboard/google/cyan/Kconfig b/src/mainboard/google/cyan/Kconfig index a3db6d7..0cefbcb 100644 --- a/src/mainboard/google/cyan/Kconfig +++ b/src/mainboard/google/cyan/Kconfig @@ -36,7 +36,6 @@ default "google/cyan"
config MAINBOARD_FAMILY - string default "Intel_Strago" if !BOARD_GOOGLE_CYAN default ""
diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig index dd1125e..f8426d2 100644 --- a/src/mainboard/google/dedede/Kconfig +++ b/src/mainboard/google/dedede/Kconfig @@ -63,7 +63,6 @@ default "google/dedede"
config MAINBOARD_FAMILY - string default "Google_Dedede" if BOARD_GOOGLE_DEDEDE
config MAINBOARD_PART_NUMBER diff --git a/src/mainboard/google/deltaur/Kconfig b/src/mainboard/google/deltaur/Kconfig index dafd593..8b56081 100644 --- a/src/mainboard/google/deltaur/Kconfig +++ b/src/mainboard/google/deltaur/Kconfig @@ -63,7 +63,6 @@ default "google/deltaur"
config MAINBOARD_FAMILY - string default "Google_Deltaur"
config MAINBOARD_PART_NUMBER diff --git a/src/mainboard/google/drallion/Kconfig b/src/mainboard/google/drallion/Kconfig index ae10b78..896fc42 100644 --- a/src/mainboard/google/drallion/Kconfig +++ b/src/mainboard/google/drallion/Kconfig @@ -71,7 +71,6 @@ default "google/drallion"
config MAINBOARD_FAMILY - string default "Google_Drallion" if BOARD_GOOGLE_DRALLION
config MAINBOARD_PART_NUMBER diff --git a/src/mainboard/google/eve/Kconfig b/src/mainboard/google/eve/Kconfig index dcc5b38..92a8179 100644 --- a/src/mainboard/google/eve/Kconfig +++ b/src/mainboard/google/eve/Kconfig @@ -59,7 +59,6 @@ default "Eve"
config MAINBOARD_FAMILY - string default "Google_Eve"
config MAX_CPUS diff --git a/src/mainboard/google/fizz/Kconfig b/src/mainboard/google/fizz/Kconfig index 90a3dc4..6e74137 100644 --- a/src/mainboard/google/fizz/Kconfig +++ b/src/mainboard/google/fizz/Kconfig @@ -57,7 +57,6 @@ default "Endeavour" if BOARD_GOOGLE_ENDEAVOUR
config MAINBOARD_FAMILY - string default "Google_Fizz" if BOARD_GOOGLE_FIZZ default "Google_Kalista" if BOARD_GOOGLE_KARMA default "Google_Endeavour" if BOARD_GOOGLE_ENDEAVOUR diff --git a/src/mainboard/google/glados/Kconfig b/src/mainboard/google/glados/Kconfig index 9790552..069358c 100644 --- a/src/mainboard/google/glados/Kconfig +++ b/src/mainboard/google/glados/Kconfig @@ -47,7 +47,6 @@ default "Sentry" if BOARD_GOOGLE_SENTRY
config MAINBOARD_FAMILY - string default "Google_Glados"
config VARIANT_DIR diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 690acd1..2cc00e0 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -115,7 +115,6 @@ default "google/hatch"
config MAINBOARD_FAMILY - string default "Google_Hatch"
config MAINBOARD_PART_NUMBER diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig index a9ba0f5..87e188f 100644 --- a/src/mainboard/google/kahlee/Kconfig +++ b/src/mainboard/google/kahlee/Kconfig @@ -65,7 +65,6 @@ default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb"
config MAINBOARD_FAMILY - string default "Google_Kahlee"
config FMDFILE diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig index d01d95f..55789be 100644 --- a/src/mainboard/google/octopus/Kconfig +++ b/src/mainboard/google/octopus/Kconfig @@ -94,7 +94,6 @@ default "Foob" if BOARD_GOOGLE_FOOB
config MAINBOARD_FAMILY - string default "Google_Octopus"
config MAX_CPUS diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig index 74b4da6..397d55d 100644 --- a/src/mainboard/google/poppy/Kconfig +++ b/src/mainboard/google/poppy/Kconfig @@ -88,7 +88,6 @@ default "google/poppy"
config MAINBOARD_FAMILY - string default "Google_Atlas" if BOARD_GOOGLE_ATLAS default "Google_Poppy" if BOARD_GOOGLE_POPPY default "Google_Nami" if BOARD_GOOGLE_NAMI diff --git a/src/mainboard/google/reef/Kconfig b/src/mainboard/google/reef/Kconfig index df1d8c4..93dbfc4 100644 --- a/src/mainboard/google/reef/Kconfig +++ b/src/mainboard/google/reef/Kconfig @@ -77,7 +77,6 @@ default "Coral" if BOARD_GOOGLE_CORAL
config MAINBOARD_FAMILY - string default "Google_Coral" if BOARD_GOOGLE_CORAL default "Google_Reef"
diff --git a/src/mainboard/google/sarien/Kconfig b/src/mainboard/google/sarien/Kconfig index 31a770a..c8a48fc 100644 --- a/src/mainboard/google/sarien/Kconfig +++ b/src/mainboard/google/sarien/Kconfig @@ -67,7 +67,6 @@ default "google/sarien"
config MAINBOARD_FAMILY - string default "Google_Arcada" if BOARD_GOOGLE_ARCADA default "Google_Sarien" if BOARD_GOOGLE_SARIEN
diff --git a/src/mainboard/google/slippy/Kconfig b/src/mainboard/google/slippy/Kconfig index 931d3ce..950afb3 100644 --- a/src/mainboard/google/slippy/Kconfig +++ b/src/mainboard/google/slippy/Kconfig @@ -44,7 +44,6 @@ default "Wolf" if BOARD_GOOGLE_WOLF
config MAINBOARD_FAMILY - string default "Google_Slippy"
config OVERRIDE_DEVICETREE diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig index 4867fea..fdedca5 100644 --- a/src/mainboard/google/volteer/Kconfig +++ b/src/mainboard/google/volteer/Kconfig @@ -64,7 +64,6 @@ default "google/volteer"
config MAINBOARD_FAMILY - string default "Google_Volteer"
config MAINBOARD_PART_NUMBER diff --git a/src/mainboard/google/zork/Kconfig b/src/mainboard/google/zork/Kconfig index c4f6bf7..6d8028d 100644 --- a/src/mainboard/google/zork/Kconfig +++ b/src/mainboard/google/zork/Kconfig @@ -93,7 +93,6 @@ default "variants/$(CONFIG_VARIANT_DIR)/overridetree.cb"
config MAINBOARD_FAMILY - string default "Google_Zork"
config MAX_CPUS diff --git a/src/mainboard/intel/cannonlake_rvp/Kconfig b/src/mainboard/intel/cannonlake_rvp/Kconfig index 32c9487..11cef1d 100644 --- a/src/mainboard/intel/cannonlake_rvp/Kconfig +++ b/src/mainboard/intel/cannonlake_rvp/Kconfig @@ -32,7 +32,6 @@ default "Cannonlake RVP"
config MAINBOARD_FAMILY - string default "Intel_cannonlake_rvp"
config MAX_CPUS diff --git a/src/mainboard/intel/coffeelake_rvp/Kconfig b/src/mainboard/intel/coffeelake_rvp/Kconfig index 81bfc93..4ca587e 100644 --- a/src/mainboard/intel/coffeelake_rvp/Kconfig +++ b/src/mainboard/intel/coffeelake_rvp/Kconfig @@ -40,7 +40,6 @@ default "cflrvp"
config MAINBOARD_FAMILY - string default "Intel_whlrvp" if BOARD_INTEL_WHISKEYLAKE_RVP default "Intel_cmlrvp" if BOARD_INTEL_COMETLAKE_RVPU default "Intel_cflrvp" diff --git a/src/mainboard/intel/glkrvp/Kconfig b/src/mainboard/intel/glkrvp/Kconfig index 8ed2aff..3e39498 100644 --- a/src/mainboard/intel/glkrvp/Kconfig +++ b/src/mainboard/intel/glkrvp/Kconfig @@ -65,7 +65,6 @@ default "glkrvp" if BOARD_INTEL_GLKRVP
config MAINBOARD_FAMILY - string default "Intel_Glkrvp" if BOARD_INTEL_GLKRVP
config MAX_CPUS diff --git a/src/mainboard/intel/icelake_rvp/Kconfig b/src/mainboard/intel/icelake_rvp/Kconfig index 2743384..0b36af6 100644 --- a/src/mainboard/intel/icelake_rvp/Kconfig +++ b/src/mainboard/intel/icelake_rvp/Kconfig @@ -32,7 +32,6 @@ default "Icelake RVP"
config MAINBOARD_FAMILY - string default "Intel_icelake_rvp"
config MAX_CPUS diff --git a/src/mainboard/intel/jasperlake_rvp/Kconfig b/src/mainboard/intel/jasperlake_rvp/Kconfig index d6fbe81..d1db3c9 100644 --- a/src/mainboard/intel/jasperlake_rvp/Kconfig +++ b/src/mainboard/intel/jasperlake_rvp/Kconfig @@ -32,7 +32,6 @@ default "jslrvp"
config MAINBOARD_FAMILY - string default "Intel_jslrvp"
config MAX_CPUS diff --git a/src/mainboard/intel/kblrvp/Kconfig b/src/mainboard/intel/kblrvp/Kconfig index d7209c5..07894bc 100644 --- a/src/mainboard/intel/kblrvp/Kconfig +++ b/src/mainboard/intel/kblrvp/Kconfig @@ -40,7 +40,6 @@ default "Kblrvp"
config MAINBOARD_FAMILY - string default "Intel_Kblrvp"
config MAX_CPUS diff --git a/src/mainboard/intel/kunimitsu/Kconfig b/src/mainboard/intel/kunimitsu/Kconfig index d7706d1..a7e317a1 100644 --- a/src/mainboard/intel/kunimitsu/Kconfig +++ b/src/mainboard/intel/kunimitsu/Kconfig @@ -37,7 +37,6 @@ default "Kunimitsu"
config MAINBOARD_FAMILY - string default "Intel_Kunimitsu"
config MAX_CPUS diff --git a/src/mainboard/intel/saddlebrook/Kconfig b/src/mainboard/intel/saddlebrook/Kconfig index e0f2add3..acf210f 100644 --- a/src/mainboard/intel/saddlebrook/Kconfig +++ b/src/mainboard/intel/saddlebrook/Kconfig @@ -30,7 +30,6 @@ default "Skylake Saddle Brook"
config MAINBOARD_FAMILY - string default "Intel_SaddleBrook"
config MAX_CPUS diff --git a/src/mainboard/intel/tglrvp/Kconfig b/src/mainboard/intel/tglrvp/Kconfig index 437f5c6..c1a4d53 100644 --- a/src/mainboard/intel/tglrvp/Kconfig +++ b/src/mainboard/intel/tglrvp/Kconfig @@ -49,7 +49,6 @@ default "tglrvpy" if BOARD_INTEL_TGLRVP_UP4
config MAINBOARD_FAMILY - string default "Intel_tglrvp"
config MAX_CPUS diff --git a/src/mainboard/lenovo/Kconfig b/src/mainboard/lenovo/Kconfig index 467c20a..fcc554c 100644 --- a/src/mainboard/lenovo/Kconfig +++ b/src/mainboard/lenovo/Kconfig @@ -13,7 +13,6 @@ default "LENOVO"
config MAINBOARD_FAMILY - string default MAINBOARD_PART_NUMBER
endif # VENDOR_LENOVO diff --git a/src/mainboard/ocp/deltalake/Kconfig b/src/mainboard/ocp/deltalake/Kconfig index b229c94..83b5a8b 100644 --- a/src/mainboard/ocp/deltalake/Kconfig +++ b/src/mainboard/ocp/deltalake/Kconfig @@ -31,7 +31,6 @@ default "DeltaLake"
config MAINBOARD_FAMILY - string default "DeltaLake"
config MAX_SOCKET diff --git a/src/mainboard/ocp/tiogapass/Kconfig b/src/mainboard/ocp/tiogapass/Kconfig index 67c1fa9..95585bf 100644 --- a/src/mainboard/ocp/tiogapass/Kconfig +++ b/src/mainboard/ocp/tiogapass/Kconfig @@ -24,7 +24,6 @@ default "TiogaPass"
config MAINBOARD_FAMILY - string default "TiogaPass"
config FMDFILE diff --git a/src/mainboard/prodrive/hermes/Kconfig b/src/mainboard/prodrive/hermes/Kconfig index 6a79f5b..46bf390 100644 --- a/src/mainboard/prodrive/hermes/Kconfig +++ b/src/mainboard/prodrive/hermes/Kconfig @@ -22,7 +22,6 @@ if BOARD_PRODRIVE_HERMES_BASEBOARD
config MAINBOARD_FAMILY - string default "PRODRIVE_HERMES_SERIES"
config MAINBOARD_PART_NUMBER diff --git a/src/mainboard/purism/librem_bdw/Kconfig b/src/mainboard/purism/librem_bdw/Kconfig index 275594b..aaee7f2 100644 --- a/src/mainboard/purism/librem_bdw/Kconfig +++ b/src/mainboard/purism/librem_bdw/Kconfig @@ -43,7 +43,6 @@ default "Librem 15 v2" if BOARD_PURISM_LIBREM15_V2
config MAINBOARD_FAMILY - string default "Librem 13" if BOARD_PURISM_LIBREM13_V1 default "Librem 15" if BOARD_PURISM_LIBREM15_V2
diff --git a/src/mainboard/purism/librem_skl/Kconfig b/src/mainboard/purism/librem_skl/Kconfig index cd8fc66..f9d541d 100644 --- a/src/mainboard/purism/librem_skl/Kconfig +++ b/src/mainboard/purism/librem_skl/Kconfig @@ -28,7 +28,6 @@ default "librem15" if BOARD_PURISM_LIBREM15_V3 || BOARD_PURISM_LIBREM15_V4
config MAINBOARD_FAMILY - string default "Librem 13" if BOARD_PURISM_LIBREM13_V2 || BOARD_PURISM_LIBREM13_V4 default "Librem 15" if BOARD_PURISM_LIBREM15_V3 || BOARD_PURISM_LIBREM15_V4
diff --git a/src/mainboard/purism/librem_whl/Kconfig b/src/mainboard/purism/librem_whl/Kconfig index bc25fb5..a8998de 100644 --- a/src/mainboard/purism/librem_whl/Kconfig +++ b/src/mainboard/purism/librem_whl/Kconfig @@ -20,7 +20,6 @@ default "purism/librem_whl"
config MAINBOARD_FAMILY - string default "Librem Mini" if BOARD_PURISM_LIBREM_MINI
config MAINBOARD_PART_NUMBER diff --git a/src/mainboard/razer/blade_stealth_kbl/Kconfig b/src/mainboard/razer/blade_stealth_kbl/Kconfig index 532bd76..2ee582a 100644 --- a/src/mainboard/razer/blade_stealth_kbl/Kconfig +++ b/src/mainboard/razer/blade_stealth_kbl/Kconfig @@ -29,7 +29,6 @@ default 18
config MAINBOARD_FAMILY - string default "BLADE_STEALTH"
config MAINBOARD_PART_NUMBER diff --git a/src/mainboard/supermicro/x11-lga1151-series/Kconfig b/src/mainboard/supermicro/x11-lga1151-series/Kconfig index a446835..850af26 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/Kconfig +++ b/src/mainboard/supermicro/x11-lga1151-series/Kconfig @@ -18,7 +18,6 @@ if BOARD_SUPERMICRO_BASEBOARD_X11_LGA1151_SERIES
config MAINBOARD_FAMILY - string default "Supermicro_X11_LGA1151_SERIES"
config MAINBOARD_PART_NUMBER
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45123 )
Change subject: mb/Kconfig: Move MAINBOARD_FAMILY type definition to mb/Kconfig ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45123/2/src/mainboard/Kconfig File src/mainboard/Kconfig:
https://review.coreboot.org/c/coreboot/+/45123/2/src/mainboard/Kconfig@14 PS2, Line 14: config MAINBOARD_FAMILY If declared unconditionally, it renders the #ifdef in `arch/x86/smbios.c` useless. Maybe replace it with a check that the string is not empty?
https://review.coreboot.org/c/coreboot/+/45123/2/src/mainboard/Kconfig@17 PS2, Line 17: identifies the family to which a particular computer belongs I don't think this description is helpful. Would be worth to mention that this goes into the SMBIOS type1 table (not type2 which is the mainboard one, *shrug*).
https://review.coreboot.org/c/coreboot/+/45123/2/src/mainboard/Kconfig@17 PS2, Line 17: This text string identifies the family to which a particular computer belongs. Nit, should be indented with tab + 2 spaces, IIRC.
Hello build bot (Jenkins), Nico Huber, Frans Hendriks, Alexander Couzens, Patrick Rudolph, Wim Vervoorn,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45123
to look at the new patch set (#3).
Change subject: mb/Kconfig: Move MAINBOARD_FAMILY declaration to mb/Kconfig ......................................................................
mb/Kconfig: Move MAINBOARD_FAMILY declaration to mb/Kconfig
This tio make it visible in kconfig tools like menuconfig.
Change-Id: If007988496c972185bad097535c5fd30ccfcd45b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/x86/smbios.c M src/mainboard/Kconfig 2 files changed, 5 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/45123/3
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45123 )
Change subject: mb/Kconfig: Move MAINBOARD_FAMILY declaration to mb/Kconfig ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45123/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45123/3//COMMIT_MSG@10 PS3, Line 10: tio should be to I guess. Perhaps it is better to add the reason behind this in the commitmessage as well
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45123 )
Change subject: mb/Kconfig: Move MAINBOARD_FAMILY declaration to mb/Kconfig ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45123/3/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/45123/3/src/arch/x86/smbios.c@493 PS3, Line 493: if (CONFIG_MAINBOARD_FAMILY != "") wrong and not needed as 'smbios_add_string' will return "0" if empty (SMBIOS sepc - 6.1.3 Text strings)
Hello build bot (Jenkins), Nico Huber, Frans Hendriks, Alexander Couzens, Patrick Rudolph, Wim Vervoorn,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45123
to look at the new patch set (#4).
Change subject: mb/Kconfig: Move MAINBOARD_FAMILY declaration to mb/Kconfig ......................................................................
mb/Kconfig: Move MAINBOARD_FAMILY declaration to mb/Kconfig
This to make it visible defined at the right place in kconfig tools like menuconfig instead of an odd place. Also remove 'ifdef CONFIG_MAINBOARD_FAMILY' as 'smbios_add_string' will return "0" as per SMBIOS specification for empty strings (section 6.1.3).
Change-Id: If007988496c972185bad097535c5fd30ccfcd45b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/x86/smbios.c M src/mainboard/Kconfig 2 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/45123/4
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45123 )
Change subject: mb/Kconfig: Move MAINBOARD_FAMILY declaration to mb/Kconfig ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45123/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45123/3//COMMIT_MSG@10 PS3, Line 10:
tio should be to I guess. […]
Thx
https://review.coreboot.org/c/coreboot/+/45123/3/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/45123/3/src/arch/x86/smbios.c@493 PS3, Line 493: if (CONFIG_MAINBOARD_FAMILY != "")
wrong and not needed as 'smbios_add_string' will return "0" if empty (SMBIOS sepc - 6.1. […]
Done
Hello build bot (Jenkins), Nico Huber, Frans Hendriks, Alexander Couzens, Patrick Rudolph, Wim Vervoorn,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45123
to look at the new patch set (#5).
Change subject: mb/Kconfig: Move MAINBOARD_FAMILY declaration to mb/Kconfig ......................................................................
mb/Kconfig: Move MAINBOARD_FAMILY declaration to mb/Kconfig
This to make it visible defined at the right place in kconfig tools like menuconfig instead of an odd place. Also remove 'ifdef CONFIG_MAINBOARD_FAMILY' as 'smbios_add_string' will return "0" as per SMBIOS specification for empty strings (section 6.1.3).
Change-Id: If007988496c972185bad097535c5fd30ccfcd45b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/x86/smbios.c M src/mainboard/Kconfig 2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/45123/5
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45123 )
Change subject: mb/Kconfig: Move MAINBOARD_FAMILY declaration to mb/Kconfig ......................................................................
Patch Set 5: Code-Review+1
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45123 )
Change subject: mb/Kconfig: Move MAINBOARD_FAMILY declaration to mb/Kconfig ......................................................................
Abandoned
Merge Conflict
-
HAOUAS Elyes (Code Review) -
Nico Huber (Code Review)
-
Wim Vervoorn (Code Review)