Change in coreboot[master]: nb/amd/agesa/family15tn: Add the audio device to the PCI devices
Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46589 )
Change subject: nb/amd/agesa/family15tn: Add the audio device to the PCI devices ......................................................................
nb/amd/agesa/family15tn: Add the audio device to the PCI devices
Following the example of CB:7630 done for family16kb boards.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ic48c7475ceadb60f825ca9e3c3427c8a7525a266 --- M src/northbridge/amd/agesa/family15tn/pci_devs.h 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/46589/1
diff --git a/src/northbridge/amd/agesa/family15tn/pci_devs.h b/src/northbridge/amd/agesa/family15tn/pci_devs.h index ea79970..45ef546 100644 --- a/src/northbridge/amd/agesa/family15tn/pci_devs.h +++ b/src/northbridge/amd/agesa/family15tn/pci_devs.h @@ -12,6 +12,10 @@ #define GFX_FUNC 0 #define GFX_DEVFN PCI_DEVFN(GFX_DEV,GFX_FUNC)
+/* Internal Audio Controller */ +#define ACTL_FUNC 1 +#define ACTL_DEVFN PCI_DEVFN(GFX_DEV,ACTL_FUNC) + /* PCIe Ports */ #define NB_PCIE_PORT1_DEV 0x2 #define NB_PCIE_PORT2_DEV 0x3
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46589 )
Change subject: nb/amd/agesa/family15tn: Add the audio device to the PCI devices ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46589/1/src/northbridge/amd/agesa/f... File src/northbridge/amd/agesa/family15tn/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/46589/1/src/northbridge/amd/agesa/f... PS1, Line 17: #define ACTL_DEVFN PCI_DEVFN(GFX_DEV,ACTL_FUNC) space required after that ',' (ctx:VxV)
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46589 )
Change subject: nb/amd/agesa/family15tn: Add the audio device to the PCI devices ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
The Family 16h use it for IRQ routing, right?
https://review.coreboot.org/c/coreboot/+/46589/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46589/1//COMMIT_MSG@7 PS1, Line 7: nb/amd/agesa/family15tn: Add the audio device to the PCI devices Maybe:
Define macro for internel HDMI audio controller
https://review.coreboot.org/c/coreboot/+/46589/1//COMMIT_MSG@9 PS1, Line 9: CB:7630 I’d be great, if you added the git commit hash and commit message summary too, as git only understands that hash by default.
Hello build bot (Jenkins), Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46589
to look at the new patch set (#2).
Change subject: nb/amd/agesa/family15tn: define macro for internal HDMI audio controller ......................................................................
nb/amd/agesa/family15tn: define macro for internal HDMI audio controller
Following the example of CB:7630 done for family16kb boards (git commit 3ff4f85ccd9fdb7cd4885a10f025b5ab297a445f).
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ic48c7475ceadb60f825ca9e3c3427c8a7525a266 --- M src/northbridge/amd/agesa/family15tn/pci_devs.h 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/46589/2
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46589 )
Change subject: nb/amd/agesa/family15tn: define macro for internal HDMI audio controller ......................................................................
Patch Set 2:
(2 comments)
Patch Set 1: Code-Review+1
(2 comments)
The Family 16h use it for IRQ routing, right?
Yes, I got a build problem while trying to "borrow" the fam16h IRQ routing. This change resolves it.
https://review.coreboot.org/c/coreboot/+/46589/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46589/1//COMMIT_MSG@7 PS1, Line 7: nb/amd/agesa/family15tn: Add the audio device to the PCI devices
Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/46589/1//COMMIT_MSG@9 PS1, Line 9: CB:7630
I’d be great, if you added the git commit hash and commit message summary too, as git only understan […]
Done (only a commit hash, since there wasn't a commit message)
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46589 )
Change subject: nb/amd/agesa/family15tn: define macro for internal HDMI audio controller ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46589/3/src/northbridge/amd/agesa/f... File src/northbridge/amd/agesa/family15tn/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/46589/3/src/northbridge/amd/agesa/f... PS3, Line 17: #define ACTL_DEVFN PCI_DEVFN(GFX_DEV,ACTL_FUNC) space required after that ',' (ctx:VxV)
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46589 )
Change subject: nb/amd/agesa/family15tn: define macro for internal HDMI audio controller ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46589/4/src/northbridge/amd/agesa/f... File src/northbridge/amd/agesa/family15tn/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/46589/4/src/northbridge/amd/agesa/f... PS4, Line 17: #define ACTL_DEVFN PCI_DEVFN(GFX_DEV,ACTL_FUNC) space required after that ',' (ctx:VxV)
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46589 )
Change subject: nb/amd/agesa/family15tn: define macro for internal HDMI audio controller ......................................................................
Patch Set 4:
haven't had a close look at the docs, but i'd guess that that is audio controller of the integrated GPU and not the main audio controller in the FCH; might be useful to verify that and add to the comment that that is the GPU side audio controller
Hello build bot (Jenkins), Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46589
to look at the new patch set (#5).
Change subject: nb/amd/agesa/family15tn: define macro for internal HDMI audio controller ......................................................................
nb/amd/agesa/family15tn: define macro for internal HDMI audio controller
Following the example of CB:7630 done for family16kb boards (git commit 3ff4f85ccd9fdb7cd4885a10f025b5ab297a445f).
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ic48c7475ceadb60f825ca9e3c3427c8a7525a266 --- M src/northbridge/amd/agesa/family15tn/pci_devs.h 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/46589/5
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46589 )
Change subject: nb/amd/agesa/family15tn: define macro for internal HDMI audio controller ......................................................................
Patch Set 5:
Patch Set 4:
haven't had a close look at the docs, but i'd guess that that is audio controller of the integrated GPU and not the main audio controller in the FCH; might be useful to verify that and add to the comment that that is the GPU side audio controller
Done: changed a comment to "/* Integrated GPU Internal HDMI Audio Controller */" to clarify.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46589 )
Change subject: nb/amd/agesa/family15tn: define macro for internal HDMI audio controller ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46589/5/src/northbridge/amd/agesa/f... File src/northbridge/amd/agesa/family15tn/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/46589/5/src/northbridge/amd/agesa/f... PS5, Line 17: #define ACTL_DEVFN PCI_DEVFN(GFX_DEV,ACTL_FUNC) space required after that ',' (ctx:VxV)
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46589 )
Change subject: nb/amd/agesa/family15tn: define macro for internal HDMI audio controller ......................................................................
Patch Set 5: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46589 )
Change subject: nb/amd/agesa/family15tn: define macro for internal HDMI audio controller ......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46589/5/src/northbridge/amd/agesa/f... File src/northbridge/amd/agesa/family15tn/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/46589/5/src/northbridge/amd/agesa/f... PS5, Line 17: #define ACTL_DEVFN PCI_DEVFN(GFX_DEV,ACTL_FUNC)
space required after that ',' (ctx:VxV)
The whole file could be reformatted at once in a separate patch
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46589 )
Change subject: nb/amd/agesa/family15tn: define macro for internal HDMI audio controller ......................................................................
nb/amd/agesa/family15tn: define macro for internal HDMI audio controller
Following the example of CB:7630 done for family16kb boards (git commit 3ff4f85ccd9fdb7cd4885a10f025b5ab297a445f).
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ic48c7475ceadb60f825ca9e3c3427c8a7525a266 Reviewed-on: https://review.coreboot.org/c/coreboot/+/46589 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/amd/agesa/family15tn/pci_devs.h 1 file changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/northbridge/amd/agesa/family15tn/pci_devs.h b/src/northbridge/amd/agesa/family15tn/pci_devs.h index ea79970..22ce8f5 100644 --- a/src/northbridge/amd/agesa/family15tn/pci_devs.h +++ b/src/northbridge/amd/agesa/family15tn/pci_devs.h @@ -12,6 +12,10 @@ #define GFX_FUNC 0 #define GFX_DEVFN PCI_DEVFN(GFX_DEV,GFX_FUNC)
+/* Integrated GPU Internal HDMI Audio Controller */ +#define ACTL_FUNC 1 +#define ACTL_DEVFN PCI_DEVFN(GFX_DEV,ACTL_FUNC) + /* PCIe Ports */ #define NB_PCIE_PORT1_DEV 0x2 #define NB_PCIE_PORT2_DEV 0x3
-
Angel Pons (Code Review) -
build bot (Jenkins) (Code Review)
-
Felix Held (Code Review)
-
Mike Banon (Code Review)
-
Paul Menzel (Code Review)