Attention is currently required from: Nick Vaccaro, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52765 )
Change subject: device: Switch pci_dev_is_wake_source to take pci_devfn_t
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/jasperlake/elog.c:
https://review.coreboot.org/c/coreboot/+/52765/comment/f389da2e_36a276ca
PS2, Line 15: pci_devfn_t
This will need update too here and in other SoC elog.c files. Can be pushed as a separate change.
You mean `unsigned int` instead of something that makes you think it's an MMCONF-compatible devfn? 😄
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52765
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4c39e5188321c8711d6479b15065e5aaedad8f38
Gerrit-Change-Number: 52765
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 29 Apr 2021 22:44:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment