Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29934 )
Change subject: Untangle CBFS microcode updates
......................................................................
Patch Set 9:
Patch Set 9:
This seems to have broken mb/googl/{sarien,arcada}. I'm not sure what's the root cause, but I just wanted to note this in here. We might need to flip a local config value in chromium.
Hi Aaron,
is it failing to build or to boot?
boot
Is that Cannon Lake or Coffee Lake? In the former case, you
still need an external microcode binary. The Kconfig symbol
for that case was renamed from CPU_MICROCODE_CBFS_GENERATE
to CPU_MICROCODE_CBFS_EXTERNAL_BINS.
Might also still be needed for some Coffee Lake steppings.
It's whiskey lake which is using one of those two. I can't remember which honestly. I suspect it's an issue w/ an uncoordinated flag setting change. Once hear exact root cause I'll update.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29934
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib403402e240d3531640a62ce93b7a93b4ef6ca5e
Gerrit-Change-Number: 29934
Gerrit-PatchSet: 9
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: York Yang
york.yang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: dhaval v sharma
dhaval.v.sharma@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 17 Jan 2019 17:49:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment