Change in coreboot[master]: drivers/pc80/tpm: Use stopwatch for timeout-loops - coreboot-gerrit

25 Oct 2021


      Attention is currently required from: Patrick Rudolph, Christian Walter, Arthur Heymans, Werner Zeh.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58240 )
Change subject: drivers/pc80/tpm: Use stopwatch for timeout-loops
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2: 
I glanced over https://trustedcomputinggroup.org/resource/pc-client-work-group-pc-client-sp... and I'm somewhat worried about TIMEOUT_B of 2 seconds (the code only polls for about 1 second), but the original code already had this potential issue.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/58240
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8fd261c9d60a9a60509c847dbc4983bc05f41d48
Gerrit-Change-Number: 58240
Gerrit-PatchSet: 2
Gerrit-Owner: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Attention: Christian Walter christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Werner Zeh werner.zeh@siemens.com
Gerrit-Comment-Date: Mon, 25 Oct 2021 08:45:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment