Attention is currently required from: Furquan Shaikh, Jamie Ryu, Wonkyu Kim, Ravishankar Sarawadi, Tim Wawrzynczak, Julius Werner, Nick Vaccaro, Raj Astekar, Srinidhi N Kaushik.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58833 )
Change subject: src/lib: Support fallback option for fw_config
......................................................................
Patch Set 4:
(2 comments)
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/58833/comment/a6bed50d_9dbdd6c2
PS4, Line 408: FW_CONFIG_SOURCE_CBFS
why can't FW_CONFIG_SOURCE_CBFS Kconfig exist in line 398 above ?
https://review.coreboot.org/c/coreboot/+/58833/comment/6f77b591_67b927b8
PS4, Line 416: and
remove one "and"?
why not append this at line 406 itself ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58833
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I215c13a4fcb9dc3b94f73c770e704d4e353e9cff
Gerrit-Change-Number: 58833
Gerrit-PatchSet: 4
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Raj Astekar
raj.astekar@intel.com
Gerrit-Attention: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Comment-Date: Tue, 02 Nov 2021 18:47:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment