Change in coreboot[master]: lib/cbfs,commonlib/mem_pool: Make cbfs_free take const pointer - coreboot-gerrit

2 Jul 2021


      Attention is currently required from: Julius Werner.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56002 )
Change subject: lib/cbfs,commonlib/mem_pool: Make cbfs_free take const pointer
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
...
While pretty harmless, I'm not sure this is the right thing to do from a design purity point of view […]
No technical reason. I just had a const pointer variable and wasn't able to free it. I can just drop the const in my code, or avoid calling free altogether.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/56002
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie570825f9255d6499e977f6eace58589115e2552
Gerrit-Change-Number: 56002
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Fri, 02 Jul 2021 14:38:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment