Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47236 )
Change subject: drivers/i2c/rx6110sa: Delete unused defines ......................................................................
drivers/i2c/rx6110sa: Delete unused defines
The defines for RX6110SA_SLAVE_ADR and RX6110SA_I2C_CONTROLLER are not used anymore and can be deleted.
Change-Id: I3cddf7a9e2f757a22c729ae0f0ff767d55909b9c Signed-off-by: Werner Zeh werner.zeh@siemens.com --- M src/drivers/i2c/rx6110sa/rx6110sa.h 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/47236/1
diff --git a/src/drivers/i2c/rx6110sa/rx6110sa.h b/src/drivers/i2c/rx6110sa/rx6110sa.h index 91685e9..0453083 100644 --- a/src/drivers/i2c/rx6110sa/rx6110sa.h +++ b/src/drivers/i2c/rx6110sa/rx6110sa.h @@ -3,10 +3,6 @@ #ifndef _I2C_RX6110SA_H_ #define _I2C_RX6110SA_H_
-/* The address of this RTC is fixed. */ -#define RX6110SA_SLAVE_ADR 0x32 -#define RX6110SA_I2C_CONTROLLER 0 - #define RX6110SA_ACPI_NAME "ERX6" #define RX6110SA_ACPI_NAME_LEN 4
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47236 )
Change subject: drivers/i2c/rx6110sa: Delete unused defines ......................................................................
Patch Set 1:
start siemens-bot
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47236 )
Change subject: drivers/i2c/rx6110sa: Delete unused defines ......................................................................
Patch Set 3: Code-Review+2
Werner Zeh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47236 )
Change subject: drivers/i2c/rx6110sa: Delete unused defines ......................................................................
drivers/i2c/rx6110sa: Delete unused defines
The defines for RX6110SA_SLAVE_ADR and RX6110SA_I2C_CONTROLLER are not used anymore and can be deleted.
Change-Id: I3cddf7a9e2f757a22c729ae0f0ff767d55909b9c Signed-off-by: Werner Zeh werner.zeh@siemens.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47236 Tested-by: build bot (Jenkins) no-reply@coreboot.org Tested-by: siemens-bot Reviewed-by: Mario Scheithauer mario.scheithauer@siemens.com --- M src/drivers/i2c/rx6110sa/rx6110sa.h 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified siemens-bot: Verified Mario Scheithauer: Looks good to me, approved
diff --git a/src/drivers/i2c/rx6110sa/rx6110sa.h b/src/drivers/i2c/rx6110sa/rx6110sa.h index 73f43b3..557a748 100644 --- a/src/drivers/i2c/rx6110sa/rx6110sa.h +++ b/src/drivers/i2c/rx6110sa/rx6110sa.h @@ -3,10 +3,6 @@ #ifndef _I2C_RX6110SA_H_ #define _I2C_RX6110SA_H_
-/* The address of this RTC is fixed. */ -#define RX6110SA_SLAVE_ADR 0x32 -#define RX6110SA_I2C_CONTROLLER 0 - #define RX6110SA_ACPI_NAME "ERX6" #define RX6110SA_HID_NAME "RX6110SA" #define RX6110SA_HID_DESC "Real Time Clock"
-
Mario Scheithauer (Code Review) -
Werner Zeh (Code Review)