Attention is currently required from: Sridhar Siricilla, Tim Wawrzynczak, Patrick Rudolph.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55364 )
Change subject: soc/intel/alderlake: [WIP]Trigger cse_fw_sync before DRAM Init
......................................................................
Patch Set 3:
(4 comments)
File src/soc/intel/alderlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/55364/comment/d327693b_c122b8e9
PS3, Line 132: Init
initialization
https://review.coreboot.org/c/coreboot/+/55364/comment/7f96bdfe_6467d741
PS3, Line 132: Dependendcy
Dependency
https://review.coreboot.org/c/coreboot/+/55364/comment/2e6fdcc1_bb437485
PS3, Line 132: Dependendcy :CSE
` :` → `: `
https://review.coreboot.org/c/coreboot/+/55364/comment/b300e695_48a64936
PS3, Line 133: if (!s3wake) {
: if (CONFIG(SOC_INTEL_CSE_LITE_SKU))
Nit: You could put it in one line.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55364
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad7403650df8bc4e40aa6e48ccfeba95a5789a2d
Gerrit-Change-Number: 55364
Gerrit-PatchSet: 3
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 01 Sep 2021 10:06:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment