Attention is currently required from: Bob Moragues, David Wu, Nick Vaccaro, Paul Menzel, Sumeet R Pawnikar, Tarun Tuli, Zhuohao Lee.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76769?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brask/var/kuldax: Set power limit values for RPL SKUs
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76769/comment/391176eb_5fa90c53 :
PS3, Line 7: brask
This should be brya, isn't it?
File src/mainboard/google/brya/variants/kuldax/ramstage.c:
https://review.coreboot.org/c/coreboot/+/76769/comment/2e42ffa3_a6ad8f03 :
PS3, Line 19: 100000
Add comment for this PL4 value suggested by thermal team which is different from the reference document 686872.
https://review.coreboot.org/c/coreboot/+/76769/comment/2a11af7e_7bfd9801 :
PS3, Line 43: { PCI_DID_INTEL_RPL_P_ID_5, 15, 138 },
: { PCI_DID_INTEL_RPL_P_ID_4, 15, 138 },
: { PCI_DID_INTEL_RPL_P_ID_3, 15, 138 },
I'm not clear why are we maintaining two separate structures to update the same values. If someone miss to update either one, it might create an issue in the future. We might need to come up with better approach for adding these new values.
It seems originally this revise was added to differentiate for 65W BJ power at line 78.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76769?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia030d13ca276c5e8340ae3b20d6e169bb162751d
Gerrit-Change-Number: 76769
Gerrit-PatchSet: 3
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Peter Ou
peter.ou@quanta.corp-partner.google.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Bob Moragues
moragues@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Fri, 04 Aug 2023 10:58:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment