Attention is currently required from: Arthur Heymans.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80191?usp=email )
Change subject: payloads/Kconfig: Add flat binary as payload option
......................................................................
Patch Set 2:
(1 comment)
File payloads/Kconfig:
https://review.coreboot.org/c/coreboot/+/80191/comment/16ba4328_185a0e7a :
PS2, Line 96: config PAYLOAD_IS_FLAT_BINARY
Why do you need a separate Kconfig option? Won't PAYLOAD_FLAT_BINARY do?
PAYLOAD_UBOOT also uses a flat binary and selects PAYLOAD_IS_FLAT_BINARY. Therefore it needs two separate options.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80191?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If775e0846f9a5631da3fc103bdd9e6aea0be879a
Gerrit-Change-Number: 80191
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sun, 28 Jan 2024 08:06:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment