Attention is currently required from: Nico Huber, Maulik V Vaghela, Paul Menzel, Ronak Kanabar, Aamir Bohra.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45905 )
Change subject: drivers/intel/fsp2_0: Integrate FirmwareVersionInfo.h
......................................................................
Patch Set 12:
(2 comments)
File src/drivers/intel/fsp2_0/hand_off_block.c:
https://review.coreboot.org/c/coreboot/+/45905/comment/d4ff5371_66299342
PS12, Line 212: #if CONFIG(DISPLAY_FSP_VERSION_INFO) || CONFIG(DISPLAY_FSP_VERSION_INFO_2)
do we really need a guard here?
https://review.coreboot.org/c/coreboot/+/45905/comment/f1b3fe5a_0883f896
PS12, Line 226: #elif
just #if CONFIG(DISPLAY_FSP_VERSION_INFO_2) won't work ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45905
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I50f7cae9ed4fac60f91d86bdd3e884956627e4b5
Gerrit-Change-Number: 45905
Gerrit-PatchSet: 12
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Comment-Date: Tue, 02 Feb 2021 12:23:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment