Paul Menzel has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/77147?usp=email )
Change subject: Makefile: Warn if flexible array members are not at the end
......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS10:
This breaks building with GCC 13.2. The commit message does not mention this at all. I do not think, people should put through the burden to have to upgrade crossgcc to build latest coreboot right away. Please revert or add a version check.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77147?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib704f7659d3b431ce7eebb4432c5b1a4272de3d2
Gerrit-Change-Number: 77147
Gerrit-PatchSet: 10
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Jan Samek
samekh@email.cz
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Thu, 30 May 2024 21:21:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No