Attention is currently required from: Ravi kumar, Shelley Chen, Julius Werner, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52662 )
Change subject: sc7180: Add display support for mipi panels ......................................................................
Patch Set 6:
(15 comments)
File src/mainboard/google/trogdor/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119141): https://review.coreboot.org/c/coreboot/+/52662/comment/ad918524_a60c94a8 PS6, Line 104: if(CONFIG(TROGDOR_HAS_MIPI_PANEL)) space required before the open parenthesis '('
File src/soc/qualcomm/sc7180/display/dsi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119141): https://review.coreboot.org/c/coreboot/+/52662/comment/6300a538_4f04ab9f PS6, Line 65: write32(&dsi0->trig_ctrl,DSI_DMA_STREAM1 << 8 | DSI_DMA_TRIGGER_SEL); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119141): https://review.coreboot.org/c/coreboot/+/52662/comment/ac27a67a_05369529 PS6, Line 172: write32(&dsi0->int_ctrl,0x0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119141): https://review.coreboot.org/c/coreboot/+/52662/comment/f45286a4_141d5a41 PS6, Line 210: printk(BIOS_ERR, Invalid vsprintf pointer extension '%pk'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119141): https://review.coreboot.org/c/coreboot/+/52662/comment/1612ff8d_211f4027 PS6, Line 281: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119141): https://review.coreboot.org/c/coreboot/+/52662/comment/1eb25dec_254383fe PS6, Line 289: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119141): https://review.coreboot.org/c/coreboot/+/52662/comment/470aab37_b0a004c2 PS6, Line 292: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119141): https://review.coreboot.org/c/coreboot/+/52662/comment/5647fe08_fc76d41f PS6, Line 299: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119141): https://review.coreboot.org/c/coreboot/+/52662/comment/d8b97c3d_dec43f4c PS6, Line 302: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119141): https://review.coreboot.org/c/coreboot/+/52662/comment/e36d186b_a386e20a PS6, Line 319: write32(&dsi0->int_ctrl,0x0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119141): https://review.coreboot.org/c/coreboot/+/52662/comment/db00ffb5_1d9cb6dc PS6, Line 322: setbits32(&dsi0->int_ctrl,DSI_CMD_MODE_DMA_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119141): https://review.coreboot.org/c/coreboot/+/52662/comment/c03b271d_dde8f664 PS6, Line 325: setbits32(&dsi0->int_ctrl,DSI_CMD_MODE_MDP_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119141): https://review.coreboot.org/c/coreboot/+/52662/comment/b3840075_690f3e60 PS6, Line 328: setbits32(&dsi0->int_ctrl,DSI_VIDEO_MODE_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119141): https://review.coreboot.org/c/coreboot/+/52662/comment/c3bba59b_5d65afb1 PS6, Line 333: setbits32(&dsi0->int_ctrl,DSI_ERROR_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119141): https://review.coreboot.org/c/coreboot/+/52662/comment/26ff5227_1508a1e3 PS6, Line 343: if(!pinfo && !pinfo->init_cmd) space required before the open parenthesis '('
-
build bot (Jenkins) (Code Review)