Nico Huber has submitted this change. ( https://review.coreboot.org/c/libgfxinit/+/67447 )
Change subject: dp training: Fix `EQ_Delay` function ......................................................................
dp training: Fix `EQ_Delay` function
The DisplayPort v2.0 specification does not mention anything about the delay being dependent on the link bandwidth.
Change-Id: I18d118ff1bf013175290a1c9fba4d449c7b00cb4 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/libgfxinit/+/67447 Tested-by: Nico Huber nico.h@gmx.de Reviewed-by: Nico Huber nico.h@gmx.de --- M common/hw-gfx-dp_training.adb 1 file changed, 17 insertions(+), 2 deletions(-)
Approvals: Nico Huber: Verified; Looks good to me, approved
diff --git a/common/hw-gfx-dp_training.adb b/common/hw-gfx-dp_training.adb index d613d85..7b06679 100644 --- a/common/hw-gfx-dp_training.adb +++ b/common/hw-gfx-dp_training.adb @@ -310,8 +310,7 @@ function EQ_Delay return Natural is Result : Natural := 400; -- DP spec: 400us begin - if Link.Bandwidth = DP_Bandwidth_5_4 and - Link.Receiver_Caps.Aux_RD_Interval /= 0 + if Link.Receiver_Caps.Aux_RD_Interval /= 0 then Result := Natural (Link.Receiver_Caps.Aux_RD_Interval) * 4_000; end if;