[S] Change in coreboot[master]: mb/google/guybrush: enable display backlight in ramstage - coreboot-gerrit

1 Sep 2022


      Attention is currently required from: Jason Nien, Matt DeVillier, Rob Barnes, Karthik Ramasubramanian.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67246 )
Change subject: mb/google/guybrush: enable display backlight in ramstage
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/67246/comment/04b357c5_50ebc524 
PS1, Line 141: PAD_GPO
...
Martin's recollection was that the ACPI code is required in order to have the backlight level restor […]
The pin seems to be in the S5 domain, so it should retain its value
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/67246
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2519d779954ed89486045aa7de0b18f1c31a4374
Gerrit-Change-Number: 67246
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Jason Nien jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Tim Van Patten timvp@google.com
Gerrit-Attention: Jason Nien jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Rob Barnes robbarnes@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Thu, 01 Sep 2022 16:00:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Comment-In-Reply-To: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-MessageType: comment