[S] Change in coreboot[master]: include/device/device_util.c: add helpers to check pci device enabled - coreboot-gerrit

4 Oct 2022


      Attention is currently required from: Fabio Aiuto, Paul Menzel, Tim Wawrzynczak, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68101 )
Change subject: include/device/device_util.c: add helpers to check pci device enabled
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File src/device/device_util.c:
https://review.coreboot.org/c/coreboot/+/68101/comment/a4da243b_45f69d50 
PS1, Line 971: pci->bus->dev->path.type
Why does this access the bus info? Can any of these pointers be NULL? The parameter itself can be NULL, too...
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/68101
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3257c8404017372f6cdd9f6cf9453502447343a0
Gerrit-Change-Number: 68101
Gerrit-PatchSet: 1
Gerrit-Owner: Fabio Aiuto fabioaiuto83@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Fabio Aiuto fabioaiuto83@gmail.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 04 Oct 2022 16:27:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment