Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37919 )
Change subject: lib/malloc: Implement a simple free() only for last malloc() ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37919/9/src/lib/malloc.c File src/lib/malloc.c:
https://review.coreboot.org/c/coreboot/+/37919/9/src/lib/malloc.c@31 PS9, Line 31: free_last_alloc_ptr = p; By placing this here you lose whatever the ALIGN() above added prior to the call so it's possible we're leaving gaps after a free(). It's probably not a big deal, but we should probably add a comment indicating it's a known property or just move it prior to ALIGN(). All this presumes we continue to die() and not return NULL.
https://review.coreboot.org/c/coreboot/+/37919/9/src/lib/malloc.c@60 PS9, Line 60: "pointing to the heap\n", __func__); fwiw,format strings are allowed to as long as needed.