Attention is currently required from: Tarun Tuli, Tim Wawrzynczak, Nick Vaccaro.
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68917 )
Change subject: mb/google/brya/variants/volmar: Add firmware config field for FP_MCU ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/volmar/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/68917/comment/85bef91e_dc26abfb PS2, Line 23: option FPMCU_ENABLED 0
Is there a reason these are backwards from all the others? It makes more sense for 0 to be disabled […]
Hi Nick,
Shipping firmware of volmar is without FP_MASK field in firmware config, and the field value was 0 in CBI for volmar.
Once the uprev firmware included the CL updated in volmar DUT,it will has no FP function as the definition: 1 = enabled ; 0 = disabled
To reserve the enabled FP function for shipping volmar DUT, we defined as 1 = disable; 0 = enabled
For zavala, we will set the field=1 (disabled) in CBI,and volmar will keep the field =0 (enabled).