Change in coreboot[master]: drivers/i2c/hid: Enforce level triggered IRQ mode - coreboot-gerrit

9 Feb 2021


      Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Karthik Ramasubramanian.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50442 )
Change subject: drivers/i2c/hid: Enforce level triggered IRQ mode
......................................................................
Patch Set 3:
(1 comment)
File src/drivers/i2c/hid/hid.c:
https://review.coreboot.org/c/coreboot/+/50442/comment/5ff27e06_65e5519d 
PS3, Line 82: 		dev->enabled = 0;
Well, what if some vendor produces devices that do not match the spec? That is not something the user can decide.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/50442
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3245a9de6e88cd83528823251083e62288192f0d
Gerrit-Change-Number: 50442
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Tue, 09 Feb 2021 23:15:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment