Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76158?usp=email )
Change subject: acpi: Set checksum for SPCR table
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
The zeroes presented in generated SPCR possibly come from a later ACPI spec than what fwts is aware of. Update FWTS ?
+ lava-test-case fwts-spcr --shell fwts spcr -q -r stdout --log-filter=SKP,PAS,FAL,ABT,INO --log-level high
<LAVA_SIGNAL_STARTTC fwts-spcr>
Received signal: <STARTTC> fwts-spcr
FAILED [HIGH] SPCRInterfaceReserved: Test 1, SPCR Serial interface type 0x12 is
a reserved interface
FAILED [HIGH] SPCRUnknownInterruptType: Test 1, SPCR interrupt type field is
zero, expecting support bits to be set
FAILED [HIGH] SPCRBaudRateReserved: Test 1, SPCR Serial baud rate type 0x00 is a
reserved baud rate
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76158?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0086a3e8c5b3a06da9edf40a7a288c534fc5a6b2
Gerrit-Change-Number: 76158
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Mon, 03 Jul 2023 06:55:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment