Attention is currently required from: Patrick Rudolph.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78225?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: sb/intel/bd82x6x: Follow PCH BIOS spec ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/southbridge/intel/bd82x6x/early_pch.c:
https://review.coreboot.org/c/coreboot/+/78225/comment/4072a09a_76518722 : PS3, Line 139: 0x1e58 might be good to add a define for this to avoid having a magic constant in here to make it a bit more obvious what this is doing. a comment pointing out that this is the case of the UM77 chipset that has less pcie ports would be fine too
-
Felix Held (Code Review)