Change in coreboot[master]: util/inteltool: Makefile: add src/arch to includes - coreboot-gerrit

16 Mar 2020


      Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39525 )
Change subject: util/inteltool: Makefile: add src/arch to includes
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39525/5/util/inteltool/Makefile 
File util/inteltool/Makefile:
https://review.coreboot.org/c/coreboot/+/39525/5/util/inteltool/Makefile@48 
PS5, Line 48: ARCH = $(subst _64,,$(shell uname -m))
...
Well, as an alternative we could copy the macros directly to inteltool
Dynamically determining the architecture seems superfluous to me.
CPPFLAGS += -I$(top)/src/arch/x86/include should work just as well and not be OS dependent, no?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/39525
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I157178a055a259e40c57f3915671d3b8966fbb96
Gerrit-Change-Number: 39525
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer:  Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com
Gerrit-Reviewer: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-Reviewer: Mimoja coreboot@mimoja.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 16 Mar 2020 11:25:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment