Attention is currently required from: Furquan Shaikh, Aseda Aboagye. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54304 )
Change subject: vboot/secdata_mock: Make v0 kernel secdata context ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54304/comment/5d5ce241_48bd8d51 PS1, Line 10: supported on systems which do _NOT_ have a v0 secdata kernel context. Like I mentioned on the bug, it doesn't. It just assumes that secdata is stored between reboots.
File src/security/vboot/secdata_mock.c:
https://review.coreboot.org/c/coreboot/+/54304/comment/a84a3697_0ab389a6 PS1, Line 31: /* Vboot implicitly assumes that EFS2 (Early Firmware Selection v2) is coreboot multi-line comment styles are either
/* * Blank line both above * and below the comment * for longer comments. */
or
/* No blank lines and no stars on continuation lines for shorter comments. */
https://review.coreboot.org/c/coreboot/+/54304/comment/ffbf3a71_c262531a PS1, Line 32: * supported on systems which do _NOT_ have a v0 secdata kernel context. (here too)
-
Julius Werner (Code Review)