Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42792 )
Change subject: libpayload: cbgfx: Replace bilinear resampling with Lanczos ......................................................................
Patch Set 15:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42792/15//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42792/15//COMMIT_MSG@9 PS15, Line 9: This patch improves the image resampling (scaling) code in CBGFX to use : the Lanczos algorithm that is widely considered the "best" resampling : algorithm (e.g. also the first choice in Python's PIL library). Do you have a test image, the differences can easily be seen with?
https://review.coreboot.org/c/coreboot/+/42792/15//COMMIT_MSG@12 PS15, Line 12: and therefore slower than bilinear : resampling It’d be great if you could provide some specific data: On <device> there is <1 ms> difference.
Can this be easily measured by enabling some option?