Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45106 )
Change subject: mb/system76/lemp9: Don't configure unused SATA / USB ports ......................................................................
mb/system76/lemp9: Don't configure unused SATA / USB ports
Change-Id: Ic5587402700d7b137e20538549b8a09a64cb6a9f Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 0 insertions(+), 33 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/45106/1
diff --git a/src/mainboard/system76/lemp9/devicetree.cb b/src/mainboard/system76/lemp9/devicetree.cb index 11232570..2e17a81 100644 --- a/src/mainboard/system76/lemp9/devicetree.cb +++ b/src/mainboard/system76/lemp9/devicetree.cb @@ -39,23 +39,8 @@ register "SataMode" = "Sata_AHCI" register "SataSalpSupport" = "0"
- register "SataPortsEnable[0]" = "0" register "SataPortsEnable[1]" = "1" register "SataPortsEnable[2]" = "1" - register "SataPortsEnable[3]" = "0" - register "SataPortsEnable[4]" = "0" - register "SataPortsEnable[5]" = "0" - register "SataPortsEnable[6]" = "0" - register "SataPortsEnable[7]" = "0" - - register "SataPortsDevSlp[0]" = "0" - register "SataPortsDevSlp[1]" = "0" - register "SataPortsDevSlp[2]" = "0" - register "SataPortsDevSlp[3]" = "0" - register "SataPortsDevSlp[4]" = "0" - register "SataPortsDevSlp[5]" = "0" - register "SataPortsDevSlp[6]" = "0" - register "SataPortsDevSlp[7]" = "0"
# Audio register "PchHdaDspEnable" = "0" @@ -77,31 +62,13 @@ register "usb2_ports[0]" = "USB2_PORT_MID(OC_SKIP)" # Type-A port 1 register "usb2_ports[1]" = "USB2_PORT_TYPE_C(OC_SKIP)" # Type-C port 2 register "usb2_ports[2]" = "USB2_PORT_MID(OC_SKIP)" # Type-A port 3 - register "usb2_ports[3]" = "USB2_PORT_EMPTY" # NC - register "usb2_ports[4]" = "USB2_PORT_EMPTY" # NC - register "usb2_ports[5]" = "USB2_PORT_EMPTY" # NC register "usb2_ports[6]" = "USB2_PORT_MAX(OC_SKIP)" # Camera - register "usb2_ports[7]" = "USB2_PORT_EMPTY" # NC - register "usb2_ports[8]" = "USB2_PORT_EMPTY" # NC register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)" # Bluetooth - register "usb2_ports[10]" = "USB2_PORT_EMPTY" # NC - register "usb2_ports[11]" = "USB2_PORT_EMPTY" # NC - register "usb2_ports[12]" = "USB2_PORT_EMPTY" # NC - register "usb2_ports[13]" = "USB2_PORT_EMPTY" # NC - register "usb2_ports[14]" = "USB2_PORT_EMPTY" # NC - register "usb2_ports[15]" = "USB2_PORT_EMPTY" # NC
# USB3 register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Type-A port 1 register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Type-C port 2 register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Type-A port 3 - register "usb3_ports[3]" = "USB3_PORT_EMPTY" # NC - register "usb3_ports[4]" = "USB3_PORT_EMPTY" # NC - register "usb3_ports[5]" = "USB3_PORT_EMPTY" # HSIO used by PCIe root port #6 - register "usb3_ports[6]" = "USB3_PORT_EMPTY" # NC - register "usb3_ports[7]" = "USB3_PORT_EMPTY" # NC - register "usb3_ports[8]" = "USB3_PORT_EMPTY" # NC - register "usb3_ports[9]" = "USB3_PORT_EMPTY" # NC
# PCI Express root port #6 x1, Clock 3 (card reader)
Hello Jeremy Soller, Michael Niewöhner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45106
to look at the new patch set (#2).
Change subject: mb/system76/lemp9: Don't configure unused SATA / USB ports ......................................................................
mb/system76/lemp9: Don't configure unused SATA / USB ports
Change-Id: Ic5587402700d7b137e20538549b8a09a64cb6a9f Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 0 insertions(+), 33 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/45106/2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45106 )
Change subject: mb/system76/lemp9: Don't configure unused SATA / USB ports ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45106/2/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/45106/2/src/mainboard/system76/lemp... PS2, Line 98: USB3_PORT_EMPTY USB3_PORT_EMPTY sets ocpin=OC_SKIP (=0xff). not setting a port here means OC pin 0 is set. should we globally initialize usbX_ports to USBX_PORT_EMPTY in soc/intel?
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45106 )
Change subject: mb/system76/lemp9: Don't configure unused SATA / USB ports ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/45106/2/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/45106/2/src/mainboard/system76/lemp... PS2, Line 52: register "SataPortsDevSlp[1]" = "0" : register "SataPortsDevSlp[2]" = "0" : devsleep is supported, so we should enabled it (iirc actually this does not enabled devsleep but enables the capability; the os is responsible for enabling); should be done in another patch; same for SataSalpSupport
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45106 )
Change subject: mb/system76/lemp9: Don't configure unused SATA / USB ports ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45106/2/src/mainboard/system76/lemp... File src/mainboard/system76/lemp9/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/45106/2/src/mainboard/system76/lemp... PS2, Line 98: USB3_PORT_EMPTY
USB3_PORT_EMPTY sets ocpin=OC_SKIP (=0xff). not setting a port here means OC pin 0 is set. […]
resolved by CB:45112
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45106 )
Change subject: mb/system76/lemp9: Don't configure unused SATA / USB ports ......................................................................
Patch Set 2: Code-Review+2
Hello build bot (Jenkins), Jeremy Soller, Michael Niewöhner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45106
to look at the new patch set (#4).
Change subject: mb/system76/lemp9: Don't configure unused SATA / USB ports ......................................................................
mb/system76/lemp9: Don't configure unused SATA / USB ports
Change-Id: Ic5587402700d7b137e20538549b8a09a64cb6a9f Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 0 insertions(+), 33 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/45106/4
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45106 )
Change subject: mb/system76/lemp9: Don't configure unused SATA / USB ports ......................................................................
mb/system76/lemp9: Don't configure unused SATA / USB ports
Change-Id: Ic5587402700d7b137e20538549b8a09a64cb6a9f Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/45106 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 0 insertions(+), 33 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/system76/lemp9/devicetree.cb b/src/mainboard/system76/lemp9/devicetree.cb index 6adc188..dc2a9fe 100644 --- a/src/mainboard/system76/lemp9/devicetree.cb +++ b/src/mainboard/system76/lemp9/devicetree.cb @@ -49,23 +49,8 @@ register "SataMode" = "Sata_AHCI" register "SataSalpSupport" = "0"
- register "SataPortsEnable[0]" = "0" register "SataPortsEnable[1]" = "1" register "SataPortsEnable[2]" = "1" - register "SataPortsEnable[3]" = "0" - register "SataPortsEnable[4]" = "0" - register "SataPortsEnable[5]" = "0" - register "SataPortsEnable[6]" = "0" - register "SataPortsEnable[7]" = "0" - - register "SataPortsDevSlp[0]" = "0" - register "SataPortsDevSlp[1]" = "0" - register "SataPortsDevSlp[2]" = "0" - register "SataPortsDevSlp[3]" = "0" - register "SataPortsDevSlp[4]" = "0" - register "SataPortsDevSlp[5]" = "0" - register "SataPortsDevSlp[6]" = "0" - register "SataPortsDevSlp[7]" = "0"
# Audio register "PchHdaDspEnable" = "0" @@ -87,31 +72,13 @@ register "usb2_ports[0]" = "USB2_PORT_MID(OC_SKIP)" # Type-A port 1 register "usb2_ports[1]" = "USB2_PORT_TYPE_C(OC_SKIP)" # Type-C port 2 register "usb2_ports[2]" = "USB2_PORT_MID(OC_SKIP)" # Type-A port 3 - register "usb2_ports[3]" = "USB2_PORT_EMPTY" # NC - register "usb2_ports[4]" = "USB2_PORT_EMPTY" # NC - register "usb2_ports[5]" = "USB2_PORT_EMPTY" # NC register "usb2_ports[6]" = "USB2_PORT_MAX(OC_SKIP)" # Camera - register "usb2_ports[7]" = "USB2_PORT_EMPTY" # NC - register "usb2_ports[8]" = "USB2_PORT_EMPTY" # NC register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)" # Bluetooth - register "usb2_ports[10]" = "USB2_PORT_EMPTY" # NC - register "usb2_ports[11]" = "USB2_PORT_EMPTY" # NC - register "usb2_ports[12]" = "USB2_PORT_EMPTY" # NC - register "usb2_ports[13]" = "USB2_PORT_EMPTY" # NC - register "usb2_ports[14]" = "USB2_PORT_EMPTY" # NC - register "usb2_ports[15]" = "USB2_PORT_EMPTY" # NC
# USB3 register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Type-A port 1 register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Type-C port 2 register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Type-A port 3 - register "usb3_ports[3]" = "USB3_PORT_EMPTY" # NC - register "usb3_ports[4]" = "USB3_PORT_EMPTY" # NC - register "usb3_ports[5]" = "USB3_PORT_EMPTY" # HSIO used by PCIe root port #6 - register "usb3_ports[6]" = "USB3_PORT_EMPTY" # NC - register "usb3_ports[7]" = "USB3_PORT_EMPTY" # NC - register "usb3_ports[8]" = "USB3_PORT_EMPTY" # NC - register "usb3_ports[9]" = "USB3_PORT_EMPTY" # NC
# PCI Express root port #6 x1, Clock 3 (card reader)
-
Felix Singer (Code Review) -
Michael Niewöhner (Code Review)