HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41697 )
Change subject: drivers/intel/fsp2_0/hand_off_block: Remove dead increment ......................................................................
drivers/intel/fsp2_0/hand_off_block: Remove dead increment
Value stored to 'size' is never read.
Change-Id: If3e96ac90f06966ee408964e0748730bc237ec19 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/intel/fsp2_0/hand_off_block.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/41697/1
diff --git a/src/drivers/intel/fsp2_0/hand_off_block.c b/src/drivers/intel/fsp2_0/hand_off_block.c index fdc92a7..380ac99 100644 --- a/src/drivers/intel/fsp2_0/hand_off_block.c +++ b/src/drivers/intel/fsp2_0/hand_off_block.c @@ -219,7 +219,6 @@ fvi = (void *)&fvih[1]; str_ptr = (char *)((uintptr_t)fvi + (fvih->Count * sizeof (FIRMWARE_VERSION_INFO))); - size -= sizeof(SMBIOS_STRUCTURE);
for (index = 0; index < fvih->Count; index++) { cnt = strlen(str_ptr);
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41697 )
Change subject: drivers/intel/fsp2_0/hand_off_block: Remove dead increment ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/41697/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41697/1//COMMIT_MSG@7 PS1, Line 7: increment nit: decrement?
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41697 )
Change subject: drivers/intel/fsp2_0/hand_off_block: Remove dead increment ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41697/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41697/1//COMMIT_MSG@7 PS1, Line 7: increment
nit: decrement?
Oops :) Thank you
Hello build bot (Jenkins), Christian Walter, Subrata Banik, Andrey Petrov, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41697
to look at the new patch set (#2).
Change subject: drivers/intel/fsp2_0/hand_off_block: Remove dead decrement ......................................................................
drivers/intel/fsp2_0/hand_off_block: Remove dead decrement
Value stored to 'size' is never read.
Change-Id: If3e96ac90f06966ee408964e0748730bc237ec19 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/intel/fsp2_0/hand_off_block.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/41697/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41697 )
Change subject: drivers/intel/fsp2_0/hand_off_block: Remove dead decrement ......................................................................
Patch Set 2:
I wonder if this is a bug or something that was left out in refactoring
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41697 )
Change subject: drivers/intel/fsp2_0/hand_off_block: Remove dead decrement ......................................................................
Patch Set 2:
Patch Set 2:
I wonder if this is a bug or something that was left out in refactoring
how to check?
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41697 )
Change subject: drivers/intel/fsp2_0/hand_off_block: Remove dead decrement ......................................................................
Patch Set 2:
I wonder if this is a bug or something that was left out in refactoring
how to check?
Now the `size` parameter is not used at all. If this is a bug depends on your quality standards. One could use the `size` parameter to check that the given structure is sane, i.e. really fits into a block of the given size.
So can we trust FSP to write proper HOBs? No => bug, yes => no bug.
I would prefer to remove the size parameter entirely. After all, the code is guarded by a debug option.
Hello build bot (Jenkins), Christian Walter, Subrata Banik, Andrey Petrov, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41697
to look at the new patch set (#3).
Change subject: drivers/intel/fsp2_0/hand_off_block: Remove dead decrement ......................................................................
drivers/intel/fsp2_0/hand_off_block: Remove dead decrement
Value stored to 'size' is never read.
Change-Id: If3e96ac90f06966ee408964e0748730bc237ec19 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/intel/fsp2_0/hand_off_block.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/41697/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41697 )
Change subject: drivers/intel/fsp2_0/hand_off_block: Remove dead decrement ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41697/3/src/drivers/intel/fsp2_0/ha... File src/drivers/intel/fsp2_0/hand_off_block.c:
https://review.coreboot.org/c/coreboot/+/41697/3/src/drivers/intel/fsp2_0/ha... PS3, Line 210: size_t size Also drop this parameter, it's unused
Hello build bot (Jenkins), Christian Walter, Subrata Banik, Andrey Petrov, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41697
to look at the new patch set (#4).
Change subject: drivers/intel/fsp2_0/hand_off_block: Remove dead decrement ......................................................................
drivers/intel/fsp2_0/hand_off_block: Remove dead decrement
Value stored to 'size' is never read.
Change-Id: If3e96ac90f06966ee408964e0748730bc237ec19 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/intel/fsp2_0/hand_off_block.c 1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/41697/4
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41697 )
Change subject: drivers/intel/fsp2_0/hand_off_block: Remove dead decrement ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41697/3/src/drivers/intel/fsp2_0/ha... File src/drivers/intel/fsp2_0/hand_off_block.c:
https://review.coreboot.org/c/coreboot/+/41697/3/src/drivers/intel/fsp2_0/ha... PS3, Line 210: size_t size
Also drop this parameter, it's unused
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41697 )
Change subject: drivers/intel/fsp2_0/hand_off_block: Remove dead decrement ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/41697/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41697/4//COMMIT_MSG@9 PS4, Line 9: Value stored to 'size' is never read. Also drop unused parameter.
Hello build bot (Jenkins), Christian Walter, Angel Pons, Subrata Banik, Andrey Petrov, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41697
to look at the new patch set (#5).
Change subject: drivers/intel/fsp2_0/hand_off_block: Remove dead decrement ......................................................................
drivers/intel/fsp2_0/hand_off_block: Remove dead decrement
Value stored to 'size' is never read. Also drop unused parameter.
Change-Id: If3e96ac90f06966ee408964e0748730bc237ec19 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/intel/fsp2_0/hand_off_block.c 1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/41697/5
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41697 )
Change subject: drivers/intel/fsp2_0/hand_off_block: Remove dead decrement ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41697/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41697/4//COMMIT_MSG@9 PS4, Line 9: Value stored to 'size' is never read.
Also drop unused parameter.
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41697 )
Change subject: drivers/intel/fsp2_0/hand_off_block: Remove dead decrement ......................................................................
drivers/intel/fsp2_0/hand_off_block: Remove dead decrement
Value stored to 'size' is never read. Also drop unused parameter.
Change-Id: If3e96ac90f06966ee408964e0748730bc237ec19 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/41697 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/drivers/intel/fsp2_0/hand_off_block.c 1 file changed, 2 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/drivers/intel/fsp2_0/hand_off_block.c b/src/drivers/intel/fsp2_0/hand_off_block.c index 44c91a2..60ab7cb 100644 --- a/src/drivers/intel/fsp2_0/hand_off_block.c +++ b/src/drivers/intel/fsp2_0/hand_off_block.c @@ -207,7 +207,7 @@ return NULL; }
-static void display_fsp_version_info_hob(const void *hob, size_t size) +static void display_fsp_version_info_hob(const void *hob) { #if CONFIG(DISPLAY_FSP_VERSION_INFO) const FIRMWARE_VERSION_INFO *fvi; @@ -219,7 +219,6 @@ fvi = (void *)&fvih[1]; str_ptr = (char *)((uintptr_t)fvi + (fvih->Count * sizeof(FIRMWARE_VERSION_INFO))); - size -= sizeof(SMBIOS_STRUCTURE);
for (index = 0; index < fvih->Count; index++) { cnt = strlen(str_ptr); @@ -279,7 +278,7 @@
if (fsp_guid_compare(hob_uuid, uuid_fv_info)) { size = hob->length - (HOB_HEADER_LEN + 16); - display_fsp_version_info_hob(hob, size); + display_fsp_version_info_hob(hob); } } }
-
Angel Pons (Code Review) -
Christian Walter (Code Review)
-
HAOUAS Elyes (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)