Attention is currently required from: Bao Zheng, Felix Held, Marshall Dawson, Zheng Bao.
Julius Werner has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/85468?usp=email )
Change subject: cbfstool: Add hash to more than one region ......................................................................
Patch Set 14:
(1 comment)
Patchset:
PS1:
For the AB recovery, we are trying to make a duplicated copy of all the modules which is needed for […]
Okay but how exactly does this differ from vboot with VBOOT_STARTS_BEFORE_BOOTBLOCK? Don't get hung up on the fact that one of the slots is called "RO", that's just naming convention. Just think of vboot's "RO" as the equivalent to your "A" slot, and vboot's "RW_A" as the equivalent to your "B" slot. (vboot's "RW_B" can be disabled in Kconfig.) It's still two slots in either case.
With vboot on AMD platforms, romstage, ramstage, bootblock and payload are also duplicated across both slots. Only the PSP stage (verstage) is shared between the two slots. Does that differ from your solution? If even the first stage exists twice, then how does the SoC decide where to boot from? And even if that exists, maybe it would be possible to expand vboot in a way that supports that rather than building a completely separate system next to it?
-
Julius Werner (Code Review)