Attention is currently required from: Henry Sun, Frank Chu, Shou-Chieh Hsu.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62315 )
Change subject: mb/google/dedede/var/galtic: Add fw_config probe for 2nd touchscreen
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/dedede/variants/galtic/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62315/comment/6bdd2219_e4148656
PS3, Line 2: 39 40
Are 2 bits sufficient?
Did you ensure that there are no conflicts with these bits - both in AP and EC FW?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62315
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id3501205b147c9dc3c96ce8381a3e7492ae8258e
Gerrit-Change-Number: 62315
Gerrit-PatchSet: 3
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Comment-Date: Wed, 02 Mar 2022 17:42:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment