Change in coreboot[master]: soc/intel/common/block/cse: Minor clean up some late comments
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35546 )
Change subject: soc/intel/common/block/cse: Minor clean up some late comments ......................................................................
Patch Set 13: Code-Review+1
(1 comment)
+2 for 3 out of the 4 points in the commit message. Generally, it's a good idea to split commits that otherwise end up with a list in the commit message. Then, a single point of the list can't drag the rest down, and it's much less work for reviewers.
https://review.coreboot.org/c/coreboot/+/35546/13/src/soc/intel/common/block... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/35546/13/src/soc/intel/common/block... PS13, Line 49: u32 bist_test_result: 1; Where is this documented?
-
Nico Huber (Code Review)